[ovs-git] Open vSwitch: ofproto-dpif: Restore former NORMAL action behavior when revalidating. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Jul 27 00:11:27 UTC 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  4cd78906a0c30cc2de0a6a0370c6b2cf1b7853b2 (commit)
       via  fc3d74089cea8f4f7d026daf922d2b89305a7364 (commit)
       via  82062a2047923e5c403fe42646e1c9eacbc73752 (commit)
      from  13b630579b8b7c67356f46b963e1256d66db0abc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4cd78906a0c30cc2de0a6a0370c6b2cf1b7853b2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4cd78906a0c30cc2de0a6a0370c6b2cf1b7853b2
Author: Ben Pfaff <blp at nicira.com>
ofproto-dpif: Restore former NORMAL action behavior when revalidating.
Before commit fa066f015 "bridge: Move packet processing functionality into
ofproto," the code that called into what became xlate_normal() prevented
a flow from being installed if it was called at revalidation time and
the MAC learning table lacked an entry for the flow's destination MAC.
That commit instead started dropping packets in that case (because it
incorrectly ignored xlate_normal()'s return value).

This restores the former behavior.  It's not clear that the former behavior
is the best possible, but it is strictly better than starting to drop
packets at revalidation time.

Along with the previously fixed problem where flood_vlans were interpreted
incorrectly, this bug broke controller connectivity when flood_vlans was
set to any nonempty value that did not include the VLAN used for the
controller connection (that is, when flood_vlans was interpreted as
flooding the controller VLAN).

Reported-by: David Tsai <dtsai at nicira.com>

commit fc3d74089cea8f4f7d026daf922d2b89305a7364
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fc3d74089cea8f4f7d026daf922d2b89305a7364
Author: Ben Pfaff <blp at nicira.com>
vlan-bitmap: Remove function vlan_bitmap_contains().
I created this function because I thought I had three good use cases.
Unfortunately, one of them was wrong, so drop it.

commit 82062a2047923e5c403fe42646e1c9eacbc73752
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=82062a2047923e5c403fe42646e1c9eacbc73752
Author: Ben Pfaff <blp at nicira.com>
mac-learning: Fix inverted logic in is_learning_vlan().
When a bit is set in flood_vlans, that VLAN must be flooded, but the logic
here was reversed in the case where there were any flooded VLANs at all.
Thus, if a single VLAN was configured to be flooded, all VLANs except that
one were actually flooded.

The common case where no VLANs were to be flooded was handled correctly.

Reported-by: David Tsai <dtsai at nicira.com>


Summary of changes:
 lib/mac-learning.c     |    2 +-
 lib/vlan-bitmap.h      |   11 ++---------
 ofproto/ofproto-dpif.c |   17 +++++++----------
 3 files changed, 10 insertions(+), 20 deletions(-)

Open vSwitch

More information about the git mailing list