[ovs-git] Open vSwitch: learning-switch: Wildcard more fields to avoid normalization warnings. (branch-1.1)

dev at openvswitch.org dev at openvswitch.org
Mon Jun 6 19:34:10 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.1 has been updated
       via  9a87628422cf1fdab12dd264531dc874a9ac2ccd (commit)
       via  58961017ea07ff1ee4f8ad520bd0e35493a7a06f (commit)
       via  e8ee90d2b5a025c0d155af652d18c8a20af4ccc0 (commit)
      from  5c48e7a9f2489ce5189db406cba485c62f0f6a14 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9a87628422cf1fdab12dd264531dc874a9ac2ccd
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9a87628422cf1fdab12dd264531dc874a9ac2ccd
Author: Ben Pfaff <blp at nicira.com>
		
learning-switch: Wildcard more fields to avoid normalization warnings.
		
FWW_NW_TOS and some other L3 fields weren't wildcarded, but should have
been.  It's better to start with all fields wildcarded and then unwildcard
the ones that shouldn't be.

Reported-by: Jean Tourrilhes <jt at hpl.hp.com>


commit 58961017ea07ff1ee4f8ad520bd0e35493a7a06f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=58961017ea07ff1ee4f8ad520bd0e35493a7a06f
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Don't warn for different forms of nw_{src,dst} wildcards.
		
OpenFlow 1.0 uses a 6-bit field to express the number of wildcarded bits
in the nw_src and nw_dst field.  Any value 32 or greater in these fields
(binary 1xxxxx) means that all of the bits are wildcarded.  That means
that there are 32 different ways to express a wildcarded nw_src or nw_dst.
At least two of those seem sensible (100000 and 111111) so we shouldn't
warn about one of them.

This fixes the problem by ORing with 100000 instead of 111111, so that any
already-correct wildcarded mask won't be affected.

This fix allows us to update some tests.

Reviewed-by: Simon Horman <horms at verge.net.au>


commit e8ee90d2b5a025c0d155af652d18c8a20af4ccc0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e8ee90d2b5a025c0d155af652d18c8a20af4ccc0
Author: Ben Pfaff <blp at nicira.com>
		
ovs-controller: Honor --wildcard option.
		
This option was documented but ignored.


-----------------------------------------------------------------------

Summary of changes:
 lib/learning-switch.c      |   11 ++++++-----
 lib/ofp-util.c             |    2 +-
 tests/ovs-ofctl.at         |   19 +------------------
 utilities/ovs-controller.c |    1 +
 4 files changed, 9 insertions(+), 24 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list