[ovs-git] Open vSwitch: ovs-brcompatd: Run ovs-vsctl instead of accessing database directly. (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  2b01925c18a52b2f7dbff5c70269a4b4d8aec027 (commit)
       via  e1f406a32b785670c72cca0c8b8acd95ea474416 (commit)
       via  780c2a5431f8e741061aabfa92effffd9c5e1ca7 (commit)
       via  5326a0fd22b8f01c5b0fd9a5763cb8ad9c885ea0 (commit)
       via  ffd66ea9e45b52eb4c6289c214cd03e8f2318369 (commit)
       via  dfeb90478917b7848c89efcc6e1674f992f1ec84 (commit)
       via  691ac3d8c5f892b8d423c8855d55fecf24abd1ae (commit)
       via  9292989d05b1a468d17bce8f6222f5344bab6b03 (commit)
      from  cb8ca532a6636d20c9d7e4a5323489cad9c3eeb7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2b01925c18a52b2f7dbff5c70269a4b4d8aec027
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2b01925c18a52b2f7dbff5c70269a4b4d8aec027
Author: Ben Pfaff <blp at nicira.com>
		
ovs-brcompatd: Run ovs-vsctl instead of accessing database directly.
		
ovs-vsctl is carefully written to avoid races in database access.  It is
much simpler to just call it than to reimplement its capabilities.

This eliminates the requirement that bridges managed by ovs-brcompatd have
no ports at ovs-brcompatd startup time.  It also eliminates races between
competing brctl and ovs-vsctl processes.


commit e1f406a32b785670c72cca0c8b8acd95ea474416
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e1f406a32b785670c72cca0c8b8acd95ea474416
Author: Ben Pfaff <blp at nicira.com>
		
ovs-brcompatd: Properly fix race between device destruction and insertion.
		
I believe that this actually fixes the race described in the comments,
whereas I'm pretty sure that the old way still left a race window.


commit 780c2a5431f8e741061aabfa92effffd9c5e1ca7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=780c2a5431f8e741061aabfa92effffd9c5e1ca7
Author: Ben Pfaff <blp at nicira.com>
		
ovs-brcompatd: Remove --prune-timeout option.
		
This option had an effect when it was initially implemented, but later it
made essentially a no-op without properly removing it or updating the
documentation.  This removes it in favor of keeping the default and only
sensible behavior.


commit 5326a0fd22b8f01c5b0fd9a5763cb8ad9c885ea0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5326a0fd22b8f01c5b0fd9a5763cb8ad9c885ea0
Author: Ben Pfaff <blp at nicira.com>
		
ovs-brcompatd: Use rtnetlink_link_notifier instead of open-coding it.
		
ovs-brcompatd has always had its own code to listen on an RTNL socket, but
I don't see any reason for it.  This commit rips it out in favor of
rtnetlink_link_notifier.

This change looks fairly big but a lot of it boils down to changing the
indentation level of rtnl_recv_update().


commit ffd66ea9e45b52eb4c6289c214cd03e8f2318369
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ffd66ea9e45b52eb4c6289c214cd03e8f2318369
Author: Ben Pfaff <blp at nicira.com>
		
ovs-vsctl: New "comment" command.
		
This allows processes that call ovs-vsctl to add remarks that explain their
intentions.


commit dfeb90478917b7848c89efcc6e1674f992f1ec84
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=dfeb90478917b7848c89efcc6e1674f992f1ec84
Author: Ben Pfaff <blp at nicira.com>
		
compiler: Add macro for GCC "sentinel" attribute.
		


commit 691ac3d8c5f892b8d423c8855d55fecf24abd1ae
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=691ac3d8c5f892b8d423c8855d55fecf24abd1ae
Author: Ben Pfaff <blp at nicira.com>
		
process: Let process_run_capture() caller set maximum capture size.
		
An upcoming patch needs a larger value.


commit 9292989d05b1a468d17bce8f6222f5344bab6b03
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9292989d05b1a468d17bce8f6222f5344bab6b03
Author: Ben Pfaff <blp at nicira.com>
		
rtnetlink-link: Avoid cast in rtnetlink_link_notifier_register().
		
It's easy enough to avoid this cast by going through a thunk function.
(The other cast in this function is harder to avoid.)

This is just a cleanup that doesn't fix any actual bug.


-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                   |    1 +
 lib/compiler.h              |    2 +
 lib/process.c               |   18 +-
 lib/process.h               |    5 +-
 lib/rtnetlink-link.c        |   10 +-
 utilities/ovs-vsctl.8.in    |    3 +
 utilities/ovs-vsctl.c       |    7 +-
 vswitchd/ovs-brcompatd.8.in |   53 +--
 vswitchd/ovs-brcompatd.c    | 1082 +++++++++++--------------------------------
 9 files changed, 317 insertions(+), 864 deletions(-)


hooks/post-receive
-- 
Open vSwitch