[ovs-git] Open vSwitch: xenserver: Run "depmod" after old modules are removed by "rpm -U". (master)

dev at openvswitch.org dev at openvswitch.org
Wed Jun 15 19:31:54 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  a4f531d87c02423a065bd667eda97cca65ac7bcd (commit)
       via  c15f1d11fa95a036eaa2504527bbd5decf082db6 (commit)
      from  05411977195ce5095c8c4a0d4b6472bdad99008e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a4f531d87c02423a065bd667eda97cca65ac7bcd
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a4f531d87c02423a065bd667eda97cca65ac7bcd
Author: Ben Pfaff <blp at nicira.com>
		
xenserver: Run "depmod" after old modules are removed by "rpm -U".
		
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets says that
package upgrade does the following steps:

    1.  %pretrans of new package
    2.  %pre of new package
    3. (package install)
    4.  %post of new package
    5.  %triggerin of other packages (set off by installing new package)
    6.  %triggerin of new package (if any are true)
    7.  %triggerun of old package (if it's set off by uninstalling the old
       package)
    8.  %triggerun of other packages (set off by uninstalling old package)
    9.  %preun of old package
   10. (removal of old package)
   11.  %postun of old package
   12.  %triggerpostun of old package (if it's set off by uninstalling the
       old package)
   13.  %triggerpostun of other packages (if they're setu off by
       uninstalling the old package)
   14.  %posttrans of new package

We're getting in trouble because the %post runs in step 4 before the
old files are removed in step 10, so depmod is finding the old modules.
This commit switches to running depmod in step 14 instead, after the
old files are removed.

Bug #5916.
Reported-by: Jesse Gross <jesse at nicira.com>
Reported-by: Henrik Amren <henrik at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit c15f1d11fa95a036eaa2504527bbd5decf082db6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c15f1d11fa95a036eaa2504527bbd5decf082db6
Author: Ben Pfaff <blp at nicira.com>
		
ovsdb-idl: Optimize out transactions that are complete no-ops.
		
Commit 1cc618c3252 "ovsdb-idl: Fix atomicity of writes that don't change a
column's value" fixed transactions that write the existing value to
some columns, ensuring that those columns still got written to the database
to avoid making the transaction nonatomic in the presence of writes that do
modify part of the database.

However, that commit was too conservative: we can still optimize out a
database transaction that writes *only* existing values to the database,
because if we drop such a transaction then the resulting database is still
one that could result from executing transactions in a serial order.  This
commit implements that optimization.

As an example of what this commit does, before this commit, an "ovs-vsctl
set" command that specified the existing value for a column would do a
round-trip to the database to write that existing value.  After this
commit, that round-trip would not occur.

Found by observing system startup.


-----------------------------------------------------------------------

Summary of changes:
 lib/ovsdb-idl.c                |   18 ++++++++++++++++--
 xenserver/openvswitch-xen.spec |    8 +++++++-
 2 files changed, 23 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list