[ovs-git] Open vSwitch: xenserver: Don't delete pidfile in stop_daemon. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Jun 16 19:28:30 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  214301739c8a05a5c206a1781d0922d9ca781dcc (commit)
       via  18547b9ebc685c90274471aa938018a47af1499e (commit)
       via  1e9092831d38457bb5c43a9ce176e418fab3d069 (commit)
       via  d3824212ada08ae285ac2e4f05dc30d97a7c25ad (commit)
      from  bae473fea5404a5afd205c70689778386045ebab (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 214301739c8a05a5c206a1781d0922d9ca781dcc
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=214301739c8a05a5c206a1781d0922d9ca781dcc
Author: Ben Pfaff <blp at nicira.com>
		
xenserver: Don't delete pidfile in stop_daemon.
		
Deleting the pidfile introduces a minor race: if some other process is
starting a daemon at the same time that the init script is stopping the
same daemon, then this could delete the new daemon's pidfile.

This is really a theoretical risk, because no one should be starting and
stopping a single daemon at the same time.


commit 18547b9ebc685c90274471aa938018a47af1499e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=18547b9ebc685c90274471aa938018a47af1499e
Author: Ben Pfaff <blp at nicira.com>
		
xenserver: Don't require confirmation to restart vswitch.
		
Early development versions of ovs-vswitchd didn't always restart
successfully, so we required confirmation if "restart" was invoked
interactively.  Recent versions do just fine, so drop the confirmation
prompt.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 1e9092831d38457bb5c43a9ce176e418fab3d069
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1e9092831d38457bb5c43a9ce176e418fab3d069
Author: Ben Pfaff <blp at nicira.com>
		
xenserver: Use $OVS_XAPI_SYNC_PIDFILE consistently.
		
This variable was used in some places but not in others.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit d3824212ada08ae285ac2e4f05dc30d97a7c25ad
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d3824212ada08ae285ac2e4f05dc30d97a7c25ad
Author: Ben Pfaff <blp at nicira.com>
		
daemon: Disable logging to console after detaching.
		
When we detach, we replace stderr by /dev/null, so there's no point in
logging to the console after that.  Just turn it off.


-----------------------------------------------------------------------

Summary of changes:
 lib/daemon.c                     |    3 ++
 xenserver/etc_init.d_openvswitch |   40 +++----------------------------------
 2 files changed, 7 insertions(+), 36 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list