[ovs-git] Open vSwitch: datapath: Avoid freeing wild pointer in corner case. (branch-1.1)

dev at openvswitch.org dev at openvswitch.org
Tue May 3 18:30:27 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.1 has been updated
       via  3594990b070f8cd6df9d7693cacb8ff4d91429fe (commit)
       via  fcbd99e69cb74ba1775ab5dc2f62988ba5194e5c (commit)
       via  deb69d98fc6039114d07db9488bdc497365b1c7d (commit)
       via  e6ed263114e071865884531f5756d7d30035d93d (commit)
       via  7174e5aed2a6d2877c1760d2ae921ae24d7accb5 (commit)
       via  ca09af69b3aa81ce257d89a36375ba163c9d09ba (commit)
       via  f64503041d96729427b8d882e3b7fd3552b43a6a (commit)
       via  66105f0e2cbd40d64bb80d77fff9c65014577050 (commit)
       via  2401d853a400babaa2c7254851e751d3db9af8cb (commit)
       via  4896c8a0d7e7f6edd1995b81f0f9868ac953a485 (commit)
       via  43c5c3bcb0de449f2489cb826020752f1162c0be (commit)
       via  2556693b6dfa48afdd39c891350fb6e0a8013374 (commit)
       via  c100c5cadcfbaf2fb55720f94c385cc0955a520a (commit)
       via  0fc2dcf0c768e23dc1cf359466b1e022b692c7c9 (commit)
       via  b222407f24d79c8394093855cdb1890e879435dd (commit)
       via  8b428d022af5848be323f6b125f896850375b8b6 (commit)
       via  7126d93814da306e4f1a7ce7ff3e91eb3fb3a64c (commit)
       via  101c55a1af7998a009a5c88c20e30837bc1a9765 (commit)
       via  54ebd8ea7dfdd53e36ef4e0cd0877d52dd95a8ad (commit)
       via  e935e9499760e11ca20f8d17b9dc28f305a20386 (commit)
       via  0725fe8cc5789b7ac13b69880ba072b153f571ad (commit)
       via  280c6e99fd5fcdaff5af6990f0c346d113d90cde (commit)
       via  9bc9a30b991f628bade1e7ddea60eded6dcdadb7 (commit)
       via  565556847b764ae3ebdebab3ee2cf3d8f44667a2 (commit)
       via  7b452aad2f0d1320b04a8ef0d5c2416d287ab805 (commit)
       via  01cdda7f229078cc81980365928b4b7e2b567a1e (commit)
       via  95a224c5f4ea3558f67c9f9f28e6e8309d8b8c9a (commit)
       via  cb447687e9c37bc5ecf4bddc2a2c2e744becc16d (commit)
       via  37865d539dabd50321ee252173d853676ee0a7d8 (commit)
       via  8fb32694154c620dce9ff0379a744178f73c1c89 (commit)
       via  a328a943f173391cd9a9a54e257c8dabcd463402 (commit)
       via  c84933bf9a73e334207b6b309749d9e9c3b04812 (commit)
       via  83ddfb6b48053f0fe202e5f7934e60b81720952b (commit)
       via  e109d9121e3847f891457ef753e35ad8a87f60b0 (commit)
      from  7f1aca9025d638d53ca1dd7cea03f5aeb02d4702 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3594990b070f8cd6df9d7693cacb8ff4d91429fe
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3594990b070f8cd6df9d7693cacb8ff4d91429fe
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Avoid freeing wild pointer in corner case.
		
In odp_flow_cmd_new_or_set(), if flow_actions_alloc() fails in the "new
flow" case, then flow_put() will kfree() the new flow's 'sf_acts' pointer,
but nothing has initialized that pointer.  Initialize the pointer to NULL
to avoid the problem.

Found by inspection.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit fcbd99e69cb74ba1775ab5dc2f62988ba5194e5c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fcbd99e69cb74ba1775ab5dc2f62988ba5194e5c
Author: Justin Pettit <jpettit at nicira.com>
		
ovs-monitor-ipsec: Allow IKE fragmentation
		
Some (broken) firewalls do not properly pass UDP fragments, which will
prevent IKE from completing.  This commit enables the racoon option to
allow application-level fragmenting and allow security associations to
be created.


commit deb69d98fc6039114d07db9488bdc497365b1c7d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=deb69d98fc6039114d07db9488bdc497365b1c7d
Author: Andrew Evans <aevans at nicira.com>
		
datapath: Make git ignore linux-2.6/vlan.c.
		
Signed-off-by: Andrew Evans <aevans at nicira.com>


commit e6ed263114e071865884531f5756d7d30035d93d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e6ed263114e071865884531f5756d7d30035d93d
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Adjust netdev_monitor when switching netdevs.
		
This fixes a segfault in the "ofproto - mod-port" test.  The segfault
should not occur--there must be a bug in the netdev_monitor or possibly
the netdev_dummy implementation--but the netdev_monitor_remove() and
netdev_monitor_add() calls are definitely wanted here in any case to ensure
that the new netdev, not the old one, is what gets monitored.


commit 7174e5aed2a6d2877c1760d2ae921ae24d7accb5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7174e5aed2a6d2877c1760d2ae921ae24d7accb5
Author: Ben Pfaff <blp at nicira.com>
		
bridge: Tolerate missing Port and Interface records for local port.
		
Until now, ovs-vswitchd has been unable to configure IP addresses and
routes for bridges whose Bridge records lack a Port and an Interface
record for the bridge's local port (e.g. OFPP_LOCAL, the port with the
same name as the bridge itself).  When such a bridge was reconfigured,
ovs-vswitchd would output a log message that worried people.

This commit fixes the internal limitation that led to the message being
printed.

Bug #5385.


commit ca09af69b3aa81ce257d89a36375ba163c9d09ba
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ca09af69b3aa81ce257d89a36375ba163c9d09ba
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Rework and fix bugs in port change detection.
		
The OpenFlow port change detection code in update_port() is supposed to
send out an OFPT_PORT_STATUS message whenever an OpenFlow port is added or
removed or changes in some way.  This commit fixes a number of bugs that
have persisted until now.

First, if a port with a given name is removed from the datapath and a new
port with the same name but a different port number is added to the
datapath, then update_port() would report this as a port "modify" change.
Reporting this as a "modify" seems likely to confuse controllers, which
have no reason to realize that the old port was deleted and may not
understand why a port that has not been reported as added would be
modified.  (This scenario is more likely than before, because the Linux
datapath implementation no longer quickly reuses port numbers.  This
problem has actually been reported in testing.)  This commit fixes the
problem by changing update_port() to report a "delete" of the old port
followed by an "add" of the new port.

Second, suppose that a datapath initially has "eth1" on port 1 and "eth2"
on port 2.  Then, "eth1" gets removed and "eth2" is reassigned to port 1.
If update_port() is first passed "eth2", then the old implementation would
have sent out an OpenFlow "modify" notification instead of "delete"
followed by "add", which is the same as the previous scenario.  But as a
further wrinkle, it would have failed to remove "eth1", which meant that we
ended up with two "ofports" with port number 1!  This commit fixes this
problem too.

Reported-by: David Tsai <dtsai at nicira.com>
Bug #5466.
NIC-372.


commit f64503041d96729427b8d882e3b7fd3552b43a6a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f64503041d96729427b8d882e3b7fd3552b43a6a
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Consistently use netdev's name instead of ofp_phy_port name.
		
There are at least two ways to get an ofport's name: from the netdev using
netdev_get_name() or from the ofp_phy_port's 'name' member.  Some code used
one, some used the other.  This switches all relevant code to use only
netdev_get_name(), because the 'name' member in ofp_phy_port is
fixed-length and thus a long name could be truncated.

This isn't a problem under Linux since the maximum length of a network
device's name under Linux is the same as the field width in ofp_phy_port.


commit 66105f0e2cbd40d64bb80d77fff9c65014577050
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=66105f0e2cbd40d64bb80d77fff9c65014577050
Author: Ben Pfaff <blp at nicira.com>
		
socket-util: Use portable solution for setting Unix socket permissions.
		
Requested-by: Jesse Gross <jesse at nicira.com>


commit 2401d853a400babaa2c7254851e751d3db9af8cb
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2401d853a400babaa2c7254851e751d3db9af8cb
Author: Ben Pfaff <blp at nicira.com>
		
INSTALL.Linux: Mention that SSL options require building with SSL support.
		
Reported-by: Aaron Rosen <arosen at clemson.edu>


commit 4896c8a0d7e7f6edd1995b81f0f9868ac953a485
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4896c8a0d7e7f6edd1995b81f0f9868ac953a485
Author: Ben Pfaff <blp at nicira.com>
		
bridge: Avoid memory leak from RSPAN mirrors in bridge_destroy().
		
Mirrors that output to ports will be destroyed when their output ports are
destroyed, but mirrors that output to VLANs ("RSPAN" mirrors) don't get
automatically destroyed like this and we need to take care of them in a
separate loop.


commit 43c5c3bcb0de449f2489cb826020752f1162c0be
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=43c5c3bcb0de449f2489cb826020752f1162c0be
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Properly handle "tun_id"s in tun_id_from_cookie flows.
		
Just setting the tun_id field isn't enough--it's also necessary to set
the tun_id_mask.  Otherwise the call to cls_rule_zero_wildcarded_fields()
at the end of ofputil_cls_rule_from_match() will zero out the tun_id again.

This was broken by commit 8368c090cab "Implement arbitrary bitwise masks
for tun_id field" back in January.  (This makes me wonder whether we can
drop support for tun_id_from_cookie now.)

Reported-by: Dan Wendlandt <dan at nicira.com>


commit 2556693b6dfa48afdd39c891350fb6e0a8013374
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2556693b6dfa48afdd39c891350fb6e0a8013374
Author: Ben Pfaff <blp at nicira.com>
		
socket-util: Properly set socket permissions in make_unix_socket().
		
Under Linux, at least, bind and fchmod interact for Unix sockets in a way
that surprised me.  Calling fchmod() on a Unix socket successfully sets the
permissions for the socket's own inode.  But that has no effect on any
inode that has already been created in the file system by bind(), because
that inode is not the same as the one for the Unix socket itself.

However, if you bind() *after* calling fchmod(), then the bind() takes the
permissions for the new inode from the Unix socket inode, which has the
desired effect.

This also adds a more portable fallback for non-Linux systems.

Reported-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>


commit c100c5cadcfbaf2fb55720f94c385cc0955a520a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c100c5cadcfbaf2fb55720f94c385cc0955a520a
Author: Ben Pfaff <blp at nicira.com>
		
bridge: Fix VLAN selection mirroring logic.
		
The logic here did not make sense.  A packet arriving on a port is mirrored
if the port is a mirroring source port AND (not OR) the packet is in one of
the VLANs that is mirrored.

This test has been here since the mirroring code was introduced.  It seems
to me that it was never correct.


commit 0fc2dcf0c768e23dc1cf359466b1e022b692c7c9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0fc2dcf0c768e23dc1cf359466b1e022b692c7c9
Author: Ben Pfaff <blp at nicira.com>
		
bridge: Reintroduce log message that was lost (and wrong).
		
Setting the 'mac' in the Interface record for a bridge's local port has
always been ineffective, but the log message was suppressed because of a
check at too high of a level.  This commit fixes the problem.  It also
fixes the wording of the log message, which has been obsolete since the
introduction of the database.

Finally, it seems better to check for the local port before checking for a
multicast address, so this reverses the order of the checks.


commit b222407f24d79c8394093855cdb1890e879435dd
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b222407f24d79c8394093855cdb1890e879435dd
Author: Ben Pfaff <blp at nicira.com>
		
daemon: Reduce log level of "pid file is stale" message.
		
This message will appear repeatedly when ovs-vswitchd is running, if there
is any stale pidfile in /var/run/openvswitch, because ovs-vswitchd reads
all of the pidfiles in that directory periodically to update statistics.


commit 8b428d022af5848be323f6b125f896850375b8b6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8b428d022af5848be323f6b125f896850375b8b6
Author: Ben Pfaff <blp at nicira.com>
		
bridge: Initialize mirrors' uuid member.
		
Otherwise mirrors get destroyed and re-created on every reconfiguration.


commit 7126d93814da306e4f1a7ce7ff3e91eb3fb3a64c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7126d93814da306e4f1a7ce7ff3e91eb3fb3a64c
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Avoid memory leak in classifier on destruction.
		
ofproto_flush_flows() flushes the flow table but then it reintroduces flows
required by fail-open or in-band.  These are then leaked when the
classifier is destroyed a little later.

This fixes the problem by not reintroducing these flows when ofproto is
being destroyed.


commit 101c55a1af7998a009a5c88c20e30837bc1a9765
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=101c55a1af7998a009a5c88c20e30837bc1a9765
Author: Ben Pfaff <blp at nicira.com>
		
Fix calls to ctype functions.
		
The ctype functions often need casts to be fully C standards compliant.
Here's the full explanation that I used to post to comp.lang.c from time
to time when the issue came up:

    With the to*() and is*() functions, you should be careful to cast
    `char' arguments to `unsigned char' before calling them.  Type `char'
    may be signed or unsigned, depending on your compiler or its
    configuration.  If `char' is signed, then some characters have
    negative values; however, the arguments to is*() and to*() functions
    must be nonnegative (or EOF).  Casting to `unsigned char' fixes this
    problem by forcing the character to the corresponding positive value.

This fixes the following warnings from some version of GCC:

lib/ofp-parse.c:828: warning: array subscript has type 'char'
lib/ofp-print.c:617: warning: array subscript has type 'char'

Reported-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>


commit 54ebd8ea7dfdd53e36ef4e0cd0877d52dd95a8ad
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=54ebd8ea7dfdd53e36ef4e0cd0877d52dd95a8ad
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Document how to disable inactivity probes.
		
This has always been implemented but it was not documented until now.

Reported-by: Alex Yip <alex at nicira.com>


commit e935e9499760e11ca20f8d17b9dc28f305a20386
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e935e9499760e11ca20f8d17b9dc28f305a20386
Author: Ethan Jackson <ethan at nicira.com>
		
xenserver: Fix typo in RPM install message.
		


commit 0725fe8cc5789b7ac13b69880ba072b153f571ad
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0725fe8cc5789b7ac13b69880ba072b153f571ad
Author: Ethan Jackson <ethan at nicira.com>
		
xenserver: Don't openvswitch-xapi-update in bridge mode.
		
This commit causes the init scripts not to call the
openvswitch-cfg-update plugin when in bridge mode.


commit 280c6e99fd5fcdaff5af6990f0c346d113d90cde
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=280c6e99fd5fcdaff5af6990f0c346d113d90cde
Author: Ethan Jackson <ethan at nicira.com>
		
xenserver:  Warn when upgrading OVS on a bridged system.
		


commit 9bc9a30b991f628bade1e7ddea60eded6dcdadb7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9bc9a30b991f628bade1e7ddea60eded6dcdadb7
Author: Ben Pfaff <blp at nicira.com>
		
ovsdb-idl: Suppress "delete" operations for garbage-collected tables.
		
Deciding what delete operations to issue on garbage-collected tables has
been a bit of a difficult issue for ovs-vsctl.  When garbage collection was
introduced in commit c5f341a "ovsdb: Implement garbage collection",
ovs-vsctl did not issue any deletions for these tables at all.  As a side
effect, ovs-vsctl did not notice that records were going to be deleted.
That meant that when multiple commands were issued in one ovs-vsctl run,
ovs-vsctl could get confused by apparent duplicate records that did not
in fact exist.  Commit 28a14bf "ovs-vsctl: Back out garbage collection
changes" fixed the problem by putting all of the explicit deletions back
into ovs-vsctl.

However, adding these explicit deletions had the price that it then became
(again) impossible to use ovs-vsctl commands to delete duplicates, for
example to use "ovs-vsctl del-br" to delete a bridge that points to the
same Port records that some other Bridge record also does.  This commit
makes that possible again, by implementing a compromise:

    * Internally, ovs-vsctl deletes the records that it believes should be
      deleted.

    * ovsdb-idl suppresses the deletions when it makes the RPC call into
      the database server.

Bug #5358.
Reported-by: Henrik Amren <henrik at nicira.com>


commit 565556847b764ae3ebdebab3ee2cf3d8f44667a2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=565556847b764ae3ebdebab3ee2cf3d8f44667a2
Author: Ben Pfaff <blp at nicira.com>
		
debian: Do not call obsolete command "ovs-ofctl status" in ovs-bugtool.
		
This command was removed in commit 9b45d7f5d (ofproto: Get rid of archaic
"switch status" OpenFlow extension) but I didn't notice that ovs-bugtool
uses that command and forgot to remove it at the time.

Bug #5360.
Reported-by: Michael Mao <mmao at nicira.com>
Reported-by: Keith Amidon <keith at nicira.com>


commit 7b452aad2f0d1320b04a8ef0d5c2416d287ab805
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7b452aad2f0d1320b04a8ef0d5c2416d287ab805
Author: Andrew Evans <aevans at nicira.com>
		
pcap: Silence warnings about fwrite(3) return value being ignored.
		


commit 01cdda7f229078cc81980365928b4b7e2b567a1e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=01cdda7f229078cc81980365928b4b7e2b567a1e
Author: Ben Pfaff <blp at nicira.com>
		
bridge: Monitor fewer OVSDB columns.
		
By omitting columns that ovs-vswitchd does not use at all, and omitting
alerts for columns that ovs-vswitchd writes to but does not read, we can
save CPU time and bandwidth.


commit 95a224c5f4ea3558f67c9f9f28e6e8309d8b8c9a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=95a224c5f4ea3558f67c9f9f28e6e8309d8b8c9a
Author: Ben Pfaff <blp at nicira.com>
		
ovsdb-idl: Fix atomicity of writes that don't change a column's value.
		
The existing ovsdb_idl_txn_commit() drops any writes that don't change a
column's value from what was last reported by the database.  But this isn't
a valid optimization, because it breaks the atomicity of transactions.
Suppose columns A and B initially have values 1 and 2.  Client 1 writes
value 1 to both columns in one transaction.  Client 2 writes value 2 to
both columns in another transaction.  The only possible valid results for
any serial ordering of transactions are 1,1 or 2,2.  But if both clients
drop writes to columns that they have not modified, then 2,1 also becomes
possible (because client 1 just writes to B and client 2 just writes to A).

However, for write-only columns we can optimize this out because the IDL
can assume it is the only client writing to a column.

Found by inspection.


commit cb447687e9c37bc5ecf4bddc2a2c2e744becc16d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=cb447687e9c37bc5ecf4bddc2a2c2e744becc16d
Author: Ben Pfaff <blp at nicira.com>
		
daemon: Avoid races on pidfile creation.
		
Until now, if two copies of one OVS daemon started up at the same time,
then due to races in pidfile creation it was possible for both of them to
start successfully, instead of just one.  This was made worse when a
previous copy of the daemon had died abruptly, leaving a stale pidfile.

This commit implements a new pidfile creation and removal protocol that I
believe closes these races.  Now, a pidfile is asserted with "link" instead
of "rename", which prevents the race on creation, and a stale pidfile may
only be deleted by a process after it has taken a lock on it.

This may solve mysterious problems seen occasionally on vswitch restart.
I'm still puzzled by these problems, however, because I don't see anything
in our tests cases that would actually cause two copies of a daemon to
start at the same time, which as far as I can see is a necessary
precondition for the problem.


commit 37865d539dabd50321ee252173d853676ee0a7d8
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=37865d539dabd50321ee252173d853676ee0a7d8
Author: Ben Pfaff <blp at nicira.com>
		
daemon: Integrate checking for an existing pidfile into daemonize_start().
		
Until now, it has been the responsibility of an individual daemon to call
die_if_already_running() at an appropriate time.  A long time ago, this
had to happen *before* daemonizing, because once the process daemonized
itself there was no way to report failure to the process that originally
started the daemon.  With the introduction of daemonize_start(), this is
now possible, but we haven't been taking advantage of it.

Therefore, this commit integrates the die_if_already_running() call into
daemonize_start() and deletes the calls to it from individual daemons.


commit 8fb32694154c620dce9ff0379a744178f73c1c89
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8fb32694154c620dce9ff0379a744178f73c1c89
Author: Ben Pfaff <blp at nicira.com>
		
daemon: Tolerate EINTR in fork_and_wait_for_startup().
		
It seems possible that a signal coming in at the wrong time could confuse
this code.  It's always best to loop on EINTR.


commit a328a943f173391cd9a9a54e257c8dabcd463402
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a328a943f173391cd9a9a54e257c8dabcd463402
Author: Ben Pfaff <blp at nicira.com>
		
Log anything that could prevent a daemon from starting.
		
If a daemon doesn't start, we need to know why.  Being able to
consistently consult the log to find out is helpful.


commit c84933bf9a73e334207b6b309749d9e9c3b04812
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c84933bf9a73e334207b6b309749d9e9c3b04812
Author: Ben Pfaff <blp at nicira.com>
		
util: New function ovs_fatal_valist().
		
This commit adds a few initial users but more are coming up.


commit 83ddfb6b48053f0fe202e5f7934e60b81720952b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=83ddfb6b48053f0fe202e5f7934e60b81720952b
Author: Ben Pfaff <blp at nicira.com>
		
signals: New function signal_name().
		
This will acquire a new user in an upcoming commit.


commit e109d9121e3847f891457ef753e35ad8a87f60b0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e109d9121e3847f891457ef753e35ad8a87f60b0
Author: Ben Pfaff <blp at nicira.com>
		
type-props: New macro for estimating length of a decimal integer.
		


-----------------------------------------------------------------------

Summary of changes:
 AUTHORS                                            |    3 +
 INSTALL.Linux                                      |    3 +
 datapath/flow.c                                    |    1 +
 datapath/linux-2.6/.gitignore                      |    1 +
 debian/ovs-bugtool                                 |    3 +-
 debian/ovs-monitor-ipsec                           |    5 +-
 lib/command-line.c                                 |   19 +-
 lib/daemon.c                                       |  278 ++++++++++++--------
 lib/daemon.h                                       |    1 -
 lib/entropy.c                                      |    5 +-
 lib/fatal-signal.c                                 |   11 +-
 lib/ofp-parse.c                                    |    3 +-
 lib/ofp-print.c                                    |    2 +-
 lib/ofp-util.c                                     |    2 +-
 lib/ovsdb-idl.c                                    |   44 +++-
 lib/ovsdb-idl.h                                    |    4 +-
 lib/pcap.c                                         |    6 +-
 lib/process.c                                      |   38 +--
 lib/random.c                                       |    7 +-
 lib/signals.c                                      |   52 ++++-
 lib/signals.h                                      |    8 +-
 lib/socket-util.c                                  |   23 ++-
 lib/socket-util.h                                  |    4 +-
 lib/timeval.c                                      |   25 +-
 lib/timeval.h                                      |    4 +-
 lib/type-props.h                                   |    9 +-
 lib/util.c                                         |    9 +-
 lib/util.h                                         |    2 +
 lib/uuid.c                                         |    7 +-
 lib/vlog.c                                         |   27 ++-
 lib/vlog.h                                         |   13 +-
 ofproto/ofproto.c                                  |  230 +++++++++-------
 ovsdb/ovsdb-server.c                               |    1 -
 python/ovs/daemon.py                               |  201 +++++++++------
 tests/ofproto.at                                   |    8 +-
 tests/test-daemon.py                               |    5 +-
 tests/test-jsonrpc.c                               |    2 -
 tests/test-jsonrpc.py                              |    4 +-
 tests/test-timeval.c                               |    4 +-
 tests/test-type-props.c                            |   13 +-
 utilities/ovs-controller.c                         |    1 -
 utilities/ovs-dpctl.c                              |   11 +-
 utilities/ovs-ofctl.c                              |   19 +-
 utilities/ovs-openflowd.c                          |   45 ++--
 utilities/ovs-vsctl.8.in                           |   13 +-
 vswitchd/bridge.c                                  |  137 +++++++---
 vswitchd/ovs-brcompatd.c                           |   19 +-
 vswitchd/ovs-vswitchd.c                            |    5 +-
 vswitchd/vswitch.xml                               |    4 +-
 xenserver/etc_init.d_openvswitch-xapi-update       |   17 ++
 xenserver/openvswitch-xen.spec                     |   15 +-
 .../usr_share_openvswitch_scripts_ovs-xapi-sync    |    2 -
 52 files changed, 856 insertions(+), 519 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list