[ovs-git] Open vSwitch: ofproto: Resubmit statistics improperly account during failover. (master)

dev at openvswitch.org dev at openvswitch.org
Fri May 6 23:57:45 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  6f1435fc8f77e925fbdb5e5dad91d61645330c6c (commit)
      from  cc8d12f9364760456c86e92378d529c0dd9aaa66 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6f1435fc8f77e925fbdb5e5dad91d61645330c6c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6f1435fc8f77e925fbdb5e5dad91d61645330c6c
Author: Ethan Jackson <ethan at nicira.com>
		
ofproto: Resubmit statistics improperly account during failover.
		
In some cases, when a facet's actions change because it resubmits
into a different rule, it will account all packets it as accrued
in the datapath to the new rule.  Due to the algorithm we are
using, it is acceptable for a facet to miscount at most 1 second
worth of packets in this manner.  This patch implements the proper
behavior.

Generally speaking, when a facet is facet_put__() into the
datapath, the kernel returns the old flow's statistics so they may
be accounted for in user space.  These statistics are generally
pushed down to the relevant facet's resubmit children.  Before this
patch, facet_put__() did not compensate for the fact that many of
the statistics in the datapath may have been already pushed.
Thus the entire packet count stored in the datapath would be pushed
to its children instead of simply the packets which have accrued
since the last accounting.  This patch fixes the behavior by
subtracting already accounted for packets from the statistics
returned by the datapath.


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto.c |   46 +++++++++++++++++++++++++++++++++++++++-------
 1 files changed, 39 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list