[ovs-git] Open vSwitch: ofproto: Reject invalid input ports in OFPT_PACKET_OUT requests. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Nov 2 15:51:51 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  e1154f713ec8f47ff38979d76e9456b49b0bc264 (commit)
       via  68f36edfe8928be1f80c960abb63474b2ad9f920 (commit)
       via  482662745144cbe10db263bea74631bf74b31192 (commit)
       via  765899376740486ca111c62a851b6120864f5698 (commit)
       via  5a020ef3b58a46ebf8ac9b5562a84144cf13ed05 (commit)
      from  f0a3aa2ecf3c81b448edfaa8c86e5dd07ba82e3a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e1154f713ec8f47ff38979d76e9456b49b0bc264
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e1154f713ec8f47ff38979d76e9456b49b0bc264
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Reject invalid input ports in OFPT_PACKET_OUT requests.
		
Some invalid ports (those above the maximum port number supported by the
datapath, including OpenFlow reserved ports that are not translated by OVS
into some other number) will be rejected by the datapath.  It's better to
catch these early and send back an appropriate OpenFlow error code, rather
than to just get EINVAL from the kernel and have to guess at the problem.

Reported-by: Aaron Rosen <arosen at clemson.edu>


commit 68f36edfe8928be1f80c960abb63474b2ad9f920
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=68f36edfe8928be1f80c960abb63474b2ad9f920
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Add error code for bad role.
		


commit 482662745144cbe10db263bea74631bf74b31192
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=482662745144cbe10db263bea74631bf74b31192
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Issue OpenFlow error for bad table IDs.
		


commit 765899376740486ca111c62a851b6120864f5698
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=765899376740486ca111c62a851b6120864f5698
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Consistently log OpenFlow error replies.
		
Until now, logging of OpenFlow error replies sent to controllers has been
haphazard.  This commit logs them centrally, ensuring that every OpenFlow
error sent to a controller is logged.

At the same time, we can eliminate the individual log messages that a few
OpenFlow errors triggered.


commit 5a020ef3b58a46ebf8ac9b5562a84144cf13ed05
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5a020ef3b58a46ebf8ac9b5562a84144cf13ed05
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: New function ofputil_decode_msg_type_partial().
		


-----------------------------------------------------------------------

Summary of changes:
 include/openflow/nicira-ext.h |   15 +++-
 lib/ofp-util.c                |  201 +++++++++++++++++++++++++++--------------
 lib/ofp-util.h                |    2 +
 ofproto/connmgr.c             |   24 +++++-
 ofproto/ofproto-dpif.c        |    4 +
 ofproto/ofproto.c             |   78 ++++++++++------
 tests/ofp-print.at            |    2 +-
 7 files changed, 226 insertions(+), 100 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list