[ovs-git] Open vSwitch: Make unixctl_command_register() idempotent (master)

dev at openvswitch.org dev at openvswitch.org
Mon Nov 14 17:25:22 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  4895c7016139e2e59c17b1d9c39aa3eca90399da (commit)
      from  279320b8276011df3667478de6750d5a40d0c6eb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4895c7016139e2e59c17b1d9c39aa3eca90399da
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4895c7016139e2e59c17b1d9c39aa3eca90399da
Author: Simon Horman <horms at verge.net.au>
		
Make unixctl_command_register() idempotent
		
The assert() statement in unixctl_command_register() implies that it is
intended to be idempotent but inserting the same name and callback twice
would fail because:

* The callback is not stored directly in the hash, rather it the
  cb element of a struct unixctl_command which is stored in the hash.

* Insertion would be attempted even if the entry was already present.


-----------------------------------------------------------------------

Summary of changes:
 lib/unixctl.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list