[ovs-git] Open vSwitch: dpif-linux: Don't reset kernel upcall_pids unintentionally. (master)

dev at openvswitch.org dev at openvswitch.org
Mon Oct 10 17:06:09 UTC 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  a24a65747a4aaf4929e8aa51f678d3ee7d57a1e3 (commit)
      from  44ff0707f09dc09b892a9b1b0a6aad6313f5248e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a24a65747a4aaf4929e8aa51f678d3ee7d57a1e3
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a24a65747a4aaf4929e8aa51f678d3ee7d57a1e3
Author: Ben Pfaff <blp at nicira.com>
dpif-linux: Don't reset kernel upcall_pids unintentionally.
Commit b063d9f0 "datapath: Use unicast Netlink sockets for upcalls" that
introduced an 'upcall_pid' member into struct dpif_linux_vport, struct
dpif_linux_dp, and struct dpif_linux_flow neglected to do so only if the
member was nonzero.  This caused every datapath, vport, and flow operation
to supply an upcall_pid.  In particular, the netdev_set_config() called at
startup when a vport already existed caused the upcall_pid for that vport
to be reset to 0, which in turn caused all packets received on the vport to
be dropped instead of forwarded to ovs-vswitchd.

Reported-by: Shih-Hao Li <shli at nicira.com>
Bug #7714.


Summary of changes:
 lib/dpif-linux.c |   48 +++++++++++++++++++++++++++++-------------------
 lib/dpif-linux.h |    2 +-
 2 files changed, 30 insertions(+), 20 deletions(-)

Open vSwitch

More information about the git mailing list