[ovs-git] Open vSwitch: datapath: Fix tunnel reconfiguration that does not change key data. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Oct 18 20:33:35 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  b1184a78452e7160db81e379783cd18937866382 (commit)
       via  4879d4c7c9c7632dc7d684b9440ff84b823e588a (commit)
      from  a7c4eaf6358e59b8642d9c26ee7efb5fedfa2186 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b1184a78452e7160db81e379783cd18937866382
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b1184a78452e7160db81e379783cd18937866382
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Fix tunnel reconfiguration that does not change key data.
		
Without this commit, a pair of commands like
    ovs-dpctl add-if br0 gre0,type=gre,remote_ip=192.168.5.2,csum=true
    ovs-dpctl set-if br0 gre0,csum=false
would result in a csum of "true" for gre0, that is, the second command
would silently have no effect.  This could also happen when the key data
(such as remote_ip) changed but the port hash just happened to have the
same value.

This also fixes a small kernel memory leak in this case.

An upcoming commit implements the "ovs-dpctl set-if" command mentioned
above.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit 4879d4c7c9c7632dc7d684b9440ff84b823e588a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4879d4c7c9c7632dc7d684b9440ff84b823e588a
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Reject attempts to change vport type with OVS_VPORT_CMD_SET.
		
Until now this has just silently failed, but it seems to me like we should
actively reject it.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c |    4 +++-
 datapath/tunnel.c   |    2 ++
 2 files changed, 5 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list