[ovs-git] Open vSwitch: learn: Correct example in nicira-ext.h and add examples as test cases. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Oct 18 20:46:17 UTC 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  eddfcba7ed6b169030451390f47e7efb23f732af (commit)
       via  4cb3fde7c9224ca4f939852c5e7987fc5112d680 (commit)
       via  db0a4375c455bbea40aa127c954d8727013e1dc2 (commit)
       via  15c819b439d9c76e51ebc99c88e55182707732bd (commit)
      from  2c84fdf286a0f74246c7d2f2b824ba6fb2811930 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit eddfcba7ed6b169030451390f47e7efb23f732af
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=eddfcba7ed6b169030451390f47e7efb23f732af
Author: Ben Pfaff <blp at nicira.com>
learn: Correct example in nicira-ext.h and add examples as test cases.

commit 4cb3fde7c9224ca4f939852c5e7987fc5112d680
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4cb3fde7c9224ca4f939852c5e7987fc5112d680
Author: Ben Pfaff <blp at nicira.com>
learn: Check learn actions after parsing in learn_parse().
learn_parse() and learn_check() are supposed to apply the same checks, but
they are implemented very differently.  It seems best to have learn_parse()
actually call learn_check() just to be sure.

This would have caught the bug fixed in the previous commit, because
the tests actually contain instances of "learn" actions that trigger the
bug, but the tests only parsed the actions without ever doing anything
that checked them (like sending them to ovs-vswitchd over OpenFlow).

commit db0a4375c455bbea40aa127c954d8727013e1dc2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=db0a4375c455bbea40aa127c954d8727013e1dc2
Author: Ben Pfaff <blp at nicira.com>
learn: Allow read-only fields to be matched.
nxm_dst_check() requires a writable field.  Since NX_LEARN_DST_MATCH only
matches on a field and doesn't write to a field, use nxm_src_check() for
that case instead.

Bug #7507.
Reported-by: Michael Mao <mmao at nicira.com>

commit 15c819b439d9c76e51ebc99c88e55182707732bd
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=15c819b439d9c76e51ebc99c88e55182707732bd
Author: Ben Pfaff <blp at nicira.com>
nx-match: Improve log message for errors parsing NX flow matches.


Summary of changes:
 include/openflow/nicira-ext.h |    3 ++-
 lib/learn.c                   |   14 ++++++++++++--
 lib/nx-match.c                |    7 +++++--
 tests/learn.at                |   17 +++++++++++++++++
 4 files changed, 36 insertions(+), 5 deletions(-)

Open vSwitch

More information about the git mailing list