[ovs-git] Open vSwitch: ovsdb-idl: Don't even try to modify synthetic rows, instead of segfaulting. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Oct 27 17:40:18 UTC 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  9b446bfaa25c3cf44ace4821bd06c675d432df56 (commit)
      from  23edef9e61fd8c89db4a238c5526b8f44e938aaf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9b446bfaa25c3cf44ace4821bd06c675d432df56
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9b446bfaa25c3cf44ace4821bd06c675d432df56
Author: Ben Pfaff <blp at nicira.com>
ovsdb-idl: Don't even try to modify synthetic rows, instead of segfaulting.
Synthetic rows lack a lot of important metadata that the IDL adds to rows
actually obtained from the database, and it's impractical to add that
metadata to synthetic rows.  This means that the IDL functions to modify
these rows dereference null pointers and segfault.  So, it's really
important not to pass synthetic rows to such functions.  However, we've
screwed this up a number of times now and in the end it seems that it's
probably better to just ignore attempts to modify these rows.  This commit
implements that.

Feature #8013.
Reported-by: Ethan Jackson <ethan at nicira.com>


Summary of changes:
 lib/ovsdb-idl.c |   26 ++++++++++++++++++++++----
 1 files changed, 22 insertions(+), 4 deletions(-)

Open vSwitch

More information about the git mailing list