[ovs-git] Open vSwitch: ofproto-dpif: Fix VLAN and other field handling in OFPP_NORMAL. (branch-1.2)

dev at openvswitch.org dev at openvswitch.org
Mon Oct 31 17:00:56 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.2 has been updated
       via  267cee702a1bb8041b06a18bb3bc9555882fde80 (commit)
      from  b9a3e6426a388c0b136b2f19cc21dcdf8b27a8ec (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 267cee702a1bb8041b06a18bb3bc9555882fde80
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=267cee702a1bb8041b06a18bb3bc9555882fde80
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif: Fix VLAN and other field handling in OFPP_NORMAL.
		
This is a nontrivial cross-port of commit 823518f1f "ofproto-dpif: Fix VLAN
and other field handling in OFPP_NORMAL" from the "master" branch.

compose_actions(), which is part of the OFPP_NORMAL implementation, had
multiple flaws that this commit corrects.

First, it did not commit changes made to the flow by actions preceding the
output to OFPP_NORMAL.  This means that, for example, if an OpenFlow action
to modify an L2 or L3 header preceded the output to OFPP_NORMAL, then
OFPP_NORMAL would output its packets without those changes.

Second, it did not update the action_xlate_ctx's notion of the VLAN that
was currently set, in the cases where it modified the current VLAN.  This
means that actions following the output to OFPP_NORMAL could output to
unexpected VLANs.

Bug #6001.
Reported-by: Michael Mao <mmao at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif.c |   47 ++++++++++++++++++++++++++++++-----------------
 1 files changed, 30 insertions(+), 17 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list