[ovs-git] Open vSwitch: daemon.py: Silence return warning. (master)

dev at openvswitch.org dev at openvswitch.org
Mon Sep 19 18:13:57 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  2a8859b0a4fe11c6418fe07dbb9b1c403a3986b4 (commit)
       via  591c20651f18b158294d0f0456c2cb92b4051031 (commit)
       via  cadc9871c2b0962e7d8497d643f49b4e1176c5c0 (commit)
       via  50e97486ca7966922d1c2c29e84e08cbe5ac2140 (commit)
      from  a5faa982dca4666c705717db165a2e8a13592e01 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2a8859b0a4fe11c6418fe07dbb9b1c403a3986b4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2a8859b0a4fe11c6418fe07dbb9b1c403a3986b4
Author: Ethan Jackson <ethan at nicira.com>
		
daemon.py: Silence return warning.
		
Pychecker complains about __read_pidfile() having too may returns.
I personally think the function is fine, but it's easy enough to
reduce them.

python/ovs/daemon.py:395: Function (__read_pidfile) has too many
returns (12)


commit 591c20651f18b158294d0f0456c2cb92b4051031
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=591c20651f18b158294d0f0456c2cb92b4051031
Author: Ethan Jackson <ethan at nicira.com>
		
daemon.py: Don't shadow built-in 'file' variable.
		
Pychecker considers it bad style.


commit cadc9871c2b0962e7d8497d643f49b4e1176c5c0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=cadc9871c2b0962e7d8497d643f49b4e1176c5c0
Author: Ethan Jackson <ethan at nicira.com>
		
daemon.py: Whitespace cleanup.
		
The python style guide requires two newlines between top level
definitions.  This patch also removes some trailing whitespace.


commit 50e97486ca7966922d1c2c29e84e08cbe5ac2140
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=50e97486ca7966922d1c2c29e84e08cbe5ac2140
Author: Ethan Jackson <ethan at nicira.com>
		
tests: Cleanup test-daemon.py style.
		
By convention, unused arguments should be named "_" and top level
definitions should be separated by two spaces.


-----------------------------------------------------------------------

Summary of changes:
 python/ovs/daemon.py |   64 +++++++++++++++++++++++++++++++++++---------------
 tests/test-daemon.py |    5 +++-
 2 files changed, 49 insertions(+), 20 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list