[ovs-git] Open vSwitch: datapath: Fully initialize datapath before local port. (branch-1.2)

dev at openvswitch.org dev at openvswitch.org
Tue Sep 20 17:48:55 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.2 has been updated
       via  675cd7211f2336c4e8bb0d0340c5ebd9b98f5219 (commit)
      from  a09ee517a1239c96d357e2dd9facb3e71deadd9c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 675cd7211f2336c4e8bb0d0340c5ebd9b98f5219
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=675cd7211f2336c4e8bb0d0340c5ebd9b98f5219
Author: Jesse Gross <jesse at nicira.com>
		
datapath: Fully initialize datapath before local port.
		
It's possible to start receiving packets on a datapath as soon as
the internal device is created.  It's therefore important that the
datapath be fully initialized before this, which it currently isn't.
In particular, the fact that dp->stats_percpu is not yet set is
potentially fatal.  In addition, if allocation of the Netlink response
failed it would leak the percpu memory.  This fixes both problems.

Found by code inspection, in practice the datapath is probably always
done initializing before someone can send a packet on it.

Signed-off-by: Jesse Gross <jesse at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c |   78 ++++++++++++++++++++++++++++++++++++---------------
 datapath/datapath.h |    2 -
 2 files changed, 55 insertions(+), 25 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list