[ovs-git] Open vSwitch: netlink-socket: Async notifications are incompatible with other operations. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Sep 22 18:38:23 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  a838c4fe1d5c4e39e52915e6c934c8dca36d17e6 (commit)
      from  77b8ebcfd4f645f6de6dc438cb1d9f1ee4e88e0b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a838c4fe1d5c4e39e52915e6c934c8dca36d17e6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a838c4fe1d5c4e39e52915e6c934c8dca36d17e6
Author: Ben Pfaff <blp at nicira.com>
		
netlink-socket: Async notifications are incompatible with other operations.
		
A Netlink socket that receives asynchronous notifications (e.g. from a
multicast group) cannot be used for transactions or dumps, because those
operations would discard asynchronous messages that arrive while waiting
for replies.

This commit documents this issue in a comment on nl_sock_join_mcgroup().
It also removes an internal attempt to avoid mixing multicast reception
with other operations.  The attempt was incomplete, because it only
handled dumps even though ordinary transactions are also problematic.  It
seems better to remove it than to fix it because, first, all of the
existing users in OVS already separate multicast reception from other
operations and, second, an upcoming commit will start using unicast
Netlink for asynchronous notifications, which has the same issues but
doesn't use nl_sock_join_mcgroup().


-----------------------------------------------------------------------

Summary of changes:
 lib/netlink-socket.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list