[ovs-git] Open vSwitch: ovsdb-idl: Improve documentation. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Apr 12 15:29:37 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  2f92678735d089e2d2a0cb9e5f6ff3aae7ed38c0 (commit)
       via  94fbe1aae29ecb71241cde7a8ed2688fa4621e1d (commit)
       via  854a94d9d20ee57b00ed8d8503e0fd945eb52301 (commit)
       via  6da258aa4c4552a905af36340be15dcbd42b4ab6 (commit)
      from  932f36ebdb5be9decb8e95befb3acd986c811185 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2f92678735d089e2d2a0cb9e5f6ff3aae7ed38c0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2f92678735d089e2d2a0cb9e5f6ff3aae7ed38c0
Author: Ben Pfaff <blp at nicira.com>
		
ovsdb-idl: Improve documentation.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 94fbe1aae29ecb71241cde7a8ed2688fa4621e1d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=94fbe1aae29ecb71241cde7a8ed2688fa4621e1d
Author: Ben Pfaff <blp at nicira.com>
		
ovsdb-idl: Improve ovsdb_idl_txn_increment() interface.
		
The previous interface was just bizarre.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 854a94d9d20ee57b00ed8d8503e0fd945eb52301
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=854a94d9d20ee57b00ed8d8503e0fd945eb52301
Author: Ben Pfaff <blp at nicira.com>
		
ovsdb-idl: Simplify transaction retry.
		
Originally the IDL transaction state machine had a return value
TXN_TRY_AGAIN to signal the client to wait for a change in the database and
then retry its transaction.  However, this logic was incomplete, because
it was possible for the database to change before the reply to the
transaction RPC was received, in which case the client would wait for a
further change.  Commit 4fdfe5ccf84c (ovsdb-idl: Prevent occasional hang
when multiple database clients race.) fixed the problem by breaking
TXN_TRY_AGAIN into two status codes, TXN_AGAIN_WAIT that meant to wait for
a further change and TXN_AGAIN_NOW that meant that a change had already
occurred so try again immediately.

This is correct enough, but it is more complicated than necessary.  It is
simpler and just as correct to use a single "try again" status that
requires the client to wait for a change relative to the database contents
*before* the transaction was committed.  This commit makes that change.
It also changes ovsdb_idl_run()'s return type from bool to void because
its return type is hardly useful anymore.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 6da258aa4c4552a905af36340be15dcbd42b4ab6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6da258aa4c4552a905af36340be15dcbd42b4ab6
Author: Ben Pfaff <blp at nicira.com>
		
ovs-monitor-ipsec: Use same pattern as ovs-xapi-sync.
		
This does not fix an actual bug in ovs-monitor-ipsec because it does not
ever commit any changes to the database.

Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 debian/ovs-monitor-ipsec |    7 +-
 lib/ovsdb-idl.c          |  211 ++++++++++++++++++++++++++++++++++-----------
 lib/ovsdb-idl.h          |   69 +++++++++++++--
 python/ovs/db/idl.py     |  174 ++++++++++++++++++++++++++++++--------
 tests/ovsdb-idl.at       |    4 +-
 tests/test-ovsdb.c       |   29 +++++--
 tests/test-ovsdb.py      |   14 ++-
 utilities/ovs-vsctl.c    |   54 +++++-------
 vswitchd/bridge.c        |   10 ++-
 9 files changed, 427 insertions(+), 145 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list