[ovs-git] Open vSwitch: vswitchd: Clean up iface_create(). (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  cc0864659fc924b1632754168bfa939bf1942492 (commit)
       via  5344c1ac9242ceaeae7b1bfe7f765b96e9f04c8f (commit)
       via  01546f5d0798f508874729991b03cdb06f4854cf (commit)
       via  2a485ee87cd4566eb2c2ffbde6b9b67cb8b81a89 (commit)
       via  b54441b366ff133079f6adc3fc9a0f456119af46 (commit)
       via  7f81a52a98bf166c5419363f12ad369a037eb1b7 (commit)
       via  8b5da7a6138537e848b48b8a7ed534dff0693899 (commit)
      from  93f331d30ddc474d36fdf6ffd4fe1f58117b1ea2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cc0864659fc924b1632754168bfa939bf1942492
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=cc0864659fc924b1632754168bfa939bf1942492
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Clean up iface_create().
		
iface_create() did its work in an order that meant it had to do a lot more
cleanup on error paths than is otherwise needed.  This commit reorders the
work to avoid this extra cleanup.

bridge_ofproto_port_del() is no longer used after the refactoring so this
commit deletes it.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 5344c1ac9242ceaeae7b1bfe7f765b96e9f04c8f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5344c1ac9242ceaeae7b1bfe7f765b96e9f04c8f
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Make reconfiguration update port configuration again.
		
Commit bae7208e91a0 (bridge: Refactor bridge_reconfigure().) introduced
a regression in bridge reconfiguration.  Previously, reconfiguration would
update the configuration of each bridge port, so that if the controller
(or the admin) changed a port's options, then that change would propagate
to the datapath.  Following that commit, that no longer happened.

This commit restores that feature.

Bug #10972.
Reported-by: Michael Hu <mhu at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 01546f5d0798f508874729991b03cdb06f4854cf
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=01546f5d0798f508874729991b03cdb06f4854cf
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Make iface_create() return an indication of success.
		
This is the minimal change that gets the job done.  There are much nicer
ways to do this, but I'll leave that refactoring for later in the series.

The return value will have its first user in an upcoming commit.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 2a485ee87cd4566eb2c2ffbde6b9b67cb8b81a89
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2a485ee87cd4566eb2c2ffbde6b9b67cb8b81a89
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Factor code to configure netdevs out of iface_create().
		
An upcoming patch will need the same code in another function.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit b54441b366ff133079f6adc3fc9a0f456119af46
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b54441b366ff133079f6adc3fc9a0f456119af46
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Refactor iface_refresh_type() into iface_get_type().
		
The calculation that this function does will need to be used in a
context where no "struct iface" is available in an upcoming commit.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 7f81a52a98bf166c5419363f12ad369a037eb1b7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7f81a52a98bf166c5419363f12ad369a037eb1b7
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Drop 'need_refresh' member from struct iface.
		
It's no longer useful.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 8b5da7a6138537e848b48b8a7ed534dff0693899
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8b5da7a6138537e848b48b8a7ed534dff0693899
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Push ofproto_port declaration down to inner blocks.
		
Just a tiny code cleanup.

Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 vswitchd/bridge.c |  336 ++++++++++++++++++++++++++++++-----------------------
 1 files changed, 191 insertions(+), 145 deletions(-)


hooks/post-receive
-- 
Open vSwitch