[ovs-git] Open vSwitch: vswitchd: Avoid GCC warning. (branch-1.6)

dev at openvswitch.org dev at openvswitch.org
Wed Apr 25 03:19:32 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.6 has been updated
       via  fc67a92224a3e913b1d1d9640eaa74f4a4c7cb5d (commit)
       via  e38e9c0b41e34c8adf89212e621d692768b9682f (commit)
       via  2eb56b303396d852c730b3414682be13f3bb7559 (commit)
       via  ad6f1c4e8ed92a78f7ff48370b429179407eb883 (commit)
       via  b772fbb3358dc3dc956169b7f22d7fe5d9276971 (commit)
       via  b6fee8b40d82ae6bc6c8bfe65d881751213b8d9b (commit)
       via  7a13bc004d124cdc38ffc5f3cb6d7b3aefe1763b (commit)
       via  ff45fb571726c1fd7faaae8ad6742a7b7fceae56 (commit)
      from  86e8dc7b83712face2ed5811d068569100357b88 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fc67a92224a3e913b1d1d9640eaa74f4a4c7cb5d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fc67a92224a3e913b1d1d9640eaa74f4a4c7cb5d
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Avoid GCC warning.
		
GCC 4.4.5 issues the following warning without this patch:

    bridge.c: In function ‘bridge_run’:
    bridge.c:2032: error: ‘database_changed’ may be used uninitialized in
    this function

I think it's unnecessary, but it doesn't hurt to always initialize this
variable.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit e38e9c0b41e34c8adf89212e621d692768b9682f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e38e9c0b41e34c8adf89212e621d692768b9682f
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Clean up iface_create().
		
iface_create() did its work in an order that meant it had to do a lot more
cleanup on error paths than is otherwise needed.  This commit reorders the
work to avoid this extra cleanup.

bridge_ofproto_port_del() is no longer used after the refactoring so this
commit deletes it.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 2eb56b303396d852c730b3414682be13f3bb7559
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2eb56b303396d852c730b3414682be13f3bb7559
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Make reconfiguration update port configuration again.
		
Commit bae7208e91a0 (bridge: Refactor bridge_reconfigure().) introduced
a regression in bridge reconfiguration.  Previously, reconfiguration would
update the configuration of each bridge port, so that if the controller
(or the admin) changed a port's options, then that change would propagate
to the datapath.  Following that commit, that no longer happened.

This commit restores that feature.

Bug #10972.
Reported-by: Michael Hu <mhu at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit ad6f1c4e8ed92a78f7ff48370b429179407eb883
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ad6f1c4e8ed92a78f7ff48370b429179407eb883
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Make iface_create() return an indication of success.
		
This is the minimal change that gets the job done.  There are much nicer
ways to do this, but I'll leave that refactoring for later in the series.

The return value will have its first user in an upcoming commit.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit b772fbb3358dc3dc956169b7f22d7fe5d9276971
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b772fbb3358dc3dc956169b7f22d7fe5d9276971
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Factor code to configure netdevs out of iface_create().
		
An upcoming patch will need the same code in another function.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit b6fee8b40d82ae6bc6c8bfe65d881751213b8d9b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b6fee8b40d82ae6bc6c8bfe65d881751213b8d9b
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Refactor iface_refresh_type() into iface_get_type().
		
The calculation that this function does will need to be used in a
context where no "struct iface" is available in an upcoming commit.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 7a13bc004d124cdc38ffc5f3cb6d7b3aefe1763b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7a13bc004d124cdc38ffc5f3cb6d7b3aefe1763b
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Drop 'need_refresh' member from struct iface.
		
It's no longer useful.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit ff45fb571726c1fd7faaae8ad6742a7b7fceae56
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ff45fb571726c1fd7faaae8ad6742a7b7fceae56
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Push ofproto_port declaration down to inner blocks.
		
Just a tiny code cleanup.

Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 vswitchd/bridge.c |  338 ++++++++++++++++++++++++++++++-----------------------
 1 files changed, 193 insertions(+), 145 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list