[ovs-git] Open vSwitch: datapath: Relax set header validation. (branch-1.4)

dev at openvswitch.org dev at openvswitch.org
Sat Aug 4 02:31:03 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.4 has been updated
       via  631ccac7f73c0d8f8ebf4812cb4ab9c6eced2370 (commit)
      from  e49ea3c272ac91af3c30f8446cea10c5bf9438a4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 631ccac7f73c0d8f8ebf4812cb4ab9c6eced2370
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=631ccac7f73c0d8f8ebf4812cb4ab9c6eced2370
Author: Jesse Gross <jesse at nicira.com>
		
datapath: Relax set header validation.
		
When installing a flow with an action to set a particular field we
need to validate that the packets that are part of the flow actually
contain that header.  With IP we use zeroed addresses and with TCP/UDP
the check is for zeroed ports.  This check is overly broad and can catch
packets like DHCP requests that have a zero source address in a
legitimate header.  This changes the check to look for a zeroed protocol
number for IP or for both ports be zero for TCP/UDP before considering
the header to not exist.

Bug #12769

Reported-by: Ethan Jackson <ethan at nicira.com>
Signed-off-by: Jesse Gross <jesse at nicira.com>
Acked-by: Pravin B Shelar <pshelar at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c |    6 +++---
 lib/odp-util.c      |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list