[ovs-git] Open vSwitch: ofp-msgs: ofpmp_reserve() must add "more" flag when splitting stats. (master)

dev at openvswitch.org dev at openvswitch.org
Mon Aug 6 16:28:45 UTC 2012

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  79b8c36c58f979296ce2cec1e6d899fa8321bc21 (commit)
      from  1448105187550e12fe806aa4863ffa5dc397afb8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 79b8c36c58f979296ce2cec1e6d899fa8321bc21
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=79b8c36c58f979296ce2cec1e6d899fa8321bc21
Author: Ben Pfaff <blp at nicira.com>
ofp-msgs: ofpmp_reserve() must add "more" flag when splitting stats.
Commit 982697a4d2 "ofp-msgs: New approach to encoding and decoding OpenFlow
headers." introduced a bug in multipart message composition such that, when
a multipart message actually requires multiple parts, the OFPSF_REPLY_MORE
bit failed to be set on any of the parts, which in turn caused the receiver
to see a truncated reply.  This commit fixes the problem.

This commit also adds a test case that would have detected the problem and
fixes a minor bug in that test case (if an error actually occurred, then
the test case would hang).

Bug #12766.
Reported-by: James Schmidt <jschmidt at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Summary of changes:
 lib/ofp-msgs.c   |    4 ++++
 tests/ofproto.at |    3 +++
 2 files changed, 7 insertions(+), 0 deletions(-)

Open vSwitch

More information about the git mailing list