[ovs-git] Open vSwitch: rconn: Treat draining a message from the send queue as activity. (master)

dev at openvswitch.org dev at openvswitch.org
Mon Aug 6 22:09:32 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  133f2dc95454bc3052efdb58e4e26dce4860285e (commit)
       via  ca0f217af8f43eb919a2905e2d7ddb55daada482 (commit)
      from  7623f4ddb09b4393c64608446a89a3a82b6f6364 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 133f2dc95454bc3052efdb58e4e26dce4860285e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=133f2dc95454bc3052efdb58e4e26dce4860285e
Author: Ben Pfaff <blp at nicira.com>
		
rconn: Treat draining a message from the send queue as activity.
		
Until now, the rconn module has used messages received from the
controller as the sole means to determine that the connection is up.
This can interact badly with the OVS connection manager in ofproto,
which stops reading and processing messages from the receive queue
when there is a backlog in the send queue for a given connection
(because reading and processes messages is the main cause of messages
getting pushed onto the send queue).  So, if a send queue backlog
lasts more than twice the inactivity probe interval, then the
connection drops, whether the controller is sending messages or not.
Dumping a large flow table can trigger this behavior if the controller
becomes temporarily busy or if the network between OVS and a
controller is slow.  The problem can easily repeat itself, since upon
reconnection the controller will generally dump the flow table.

This commit fixes the problem by expanding the definition of
"activity" to include successfully sending an OpenFlow message that
was previously queued.

Bug #12789.
Reported-by: Natasha Gude <natasha at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit ca0f217af8f43eb919a2905e2d7ddb55daada482
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ca0f217af8f43eb919a2905e2d7ddb55daada482
Author: Ben Pfaff <blp at nicira.com>
		
rconn: Remove unused functions.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/rconn.c |   77 ++++++++++------------------------------------------------
 lib/rconn.h |    7 -----
 2 files changed, 14 insertions(+), 70 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list