[ovs-git] Open vSwitch: tests: Test that ofp10_match bytes that should be ignored really are. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Aug 7 22:37:33 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  8812ec2cdde70b6fae5163c65c7706bed08190c7 (commit)
      from  6e797088c0ff76843137c3ce0642b319b6404b7c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8812ec2cdde70b6fae5163c65c7706bed08190c7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8812ec2cdde70b6fae5163c65c7706bed08190c7
Author: Ben Pfaff <blp at nicira.com>
		
tests: Test that ofp10_match bytes that should be ignored really are.
		
Rob Sherwood reported a bug in OVS treatment of ofp10_match bytes that
should be ignored some time ago:

> In any case, the pktact.SingleWildcardMatch and
> pktact.AllExceptOneWildcardMatch tests were failing because it looks
> like OVS (v1.4 release) was  not matching vlan tagged packets when the
> match wildcarded vlan but the dl_vlan value (which should be ignored,
> because it is wildcarded) was non-zero.  We've worked around this in
> OFTest by making sure that the dl_vlan value is zero when vlan is
> wildcarded and now the test passes.
>
> In other words:
>
> if (ofp_match->wildcards&OFPFW_DL_VLAN) is true, then the match should
> match both tagged and untagged packets, independent of the value of
> ofp_match->dl_vlan.  OVS (seemingly) only matches tagged packets if
> ofp_match->dl_vlan == 0.

I wasn't able to spot the problem at the time, and I still don't see a
problem (perhaps it has been fixed since then), but this commit should
prevent any regression for this specific problem and for anything like it.

It would be natural to modify the parse-ofp11-match test in the same way,
but this commit doesn't do it.

Rob's original bug report is at:
https://mailman.stanford.edu/pipermail/openflow-discuss/2012-March/003107.html

Reported-by: Rob Sherwood <rob.sherwood at bigswitch.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 tests/ovs-ofctl.at    |  136 ++++++++++++++++++++++++------------------------
 utilities/ovs-ofctl.c |   40 +++++++++++++--
 2 files changed, 104 insertions(+), 72 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list