[ovs-git] Open vSwitch: tests: Fix MockXenAPI to make the ovs-xapi-sync test case pass again. (branch-1.7)

dev at openvswitch.org dev at openvswitch.org
Mon Aug 13 22:33:17 UTC 2012

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.7 has been updated
       via  d4552c7d37d29219b52e076c395f99a7f896984c (commit)
       via  dfdc7813da6feaf33d4be359fb64c35b3a0474da (commit)
       via  d2155157b90966c6c16cf093b3fc724812f8313b (commit)
       via  1c60dc3c8a7d61f094e3aff506a22d0c0075efe9 (commit)
      from  e353e467f08fdcad56cabf6ace93101e7174394d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d4552c7d37d29219b52e076c395f99a7f896984c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d4552c7d37d29219b52e076c395f99a7f896984c
Author: Ben Pfaff <blp at nicira.com>
tests: Fix MockXenAPI to make the ovs-xapi-sync test case pass again.
Commit a8d9dfc788 (xenserver: Improve efficiency of code by using
get_all_records_where()) updated the ovs-xapi-sync script and caused a unit
test failure.  This fixes it.

Bug #12848.
Signed-off-by: Ben Pfaff <blp at nicira.com>

commit dfdc7813da6feaf33d4be359fb64c35b3a0474da
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=dfdc7813da6feaf33d4be359fb64c35b3a0474da
Author: Rob Hoes <rob.hoes at citrix.com>
xenserver: Improve efficiency of code by using get_all_records_where()
Replace the get_record() for network references which caused as many
slave-to-master calls as there are Network records plus one.
The get_all_records_where() call gets exactly what is needed with a single

Bug #12848.
Signed-off-by: Rob Hoes <rob.hoes at citrix.com>
Acked-by: Dominic Curran <dominic.curran at citrix.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>

commit d2155157b90966c6c16cf093b3fc724812f8313b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d2155157b90966c6c16cf093b3fc724812f8313b
Author: Ben Pfaff <blp at nicira.com>
rconn: Treat draining a message from the send queue as activity.
Until now, the rconn module has used messages received from the
controller as the sole means to determine that the connection is up.
This can interact badly with the OVS connection manager in ofproto,
which stops reading and processing messages from the receive queue
when there is a backlog in the send queue for a given connection
(because reading and processes messages is the main cause of messages
getting pushed onto the send queue).  So, if a send queue backlog
lasts more than twice the inactivity probe interval, then the
connection drops, whether the controller is sending messages or not.
Dumping a large flow table can trigger this behavior if the controller
becomes temporarily busy or if the network between OVS and a
controller is slow.  The problem can easily repeat itself, since upon
reconnection the controller will generally dump the flow table.

This commit fixes the problem by expanding the definition of
"activity" to include successfully sending an OpenFlow message that
was previously queued.

Bug #12789.
Reported-by: Natasha Gude <natasha at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>

commit 1c60dc3c8a7d61f094e3aff506a22d0c0075efe9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1c60dc3c8a7d61f094e3aff506a22d0c0075efe9
Author: Ben Pfaff <blp at nicira.com>
rconn: Remove unused functions.
Signed-off-by: Ben Pfaff <blp at nicira.com>


Summary of changes:
 lib/rconn.c                                        |   77 ++++----------------
 lib/rconn.h                                        |    7 --
 tests/MockXenAPI.py                                |   18 +++++-
 .../usr_share_openvswitch_scripts_ovs-xapi-sync    |    7 +-
 4 files changed, 34 insertions(+), 75 deletions(-)

Open vSwitch

More information about the git mailing list