[ovs-git] Open vSwitch: ofproto-dpif: Make sure one-packet flows have zero duration. (branch-1.8)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.8 has been updated
       via  98fbb1f0d83b2244d544aa99de260b7dff563c40 (commit)
       via  fea9f2006afb73d065621f36efbb93a5ef1edacd (commit)
      from  8dd1e42f13296998b47b06b727ef2b070bcc294c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 98fbb1f0d83b2244d544aa99de260b7dff563c40
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=98fbb1f0d83b2244d544aa99de260b7dff563c40
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif: Make sure one-packet flows have zero duration.
		
A Nicira internal build recently failed the "ofproto-dpif - NetFlow flow
expiration" test because of the following difference in output:

     header: v5, seq 0, engine 2,1
    -rec: [...], 1 pkts, 60 bytes, ICMP 8:0, time <moment>
    +rec: [...], 1 pkts, 60 bytes, ICMP 8:0, time <range>

Looking at the actual output, it is:
    rec: 192.168.0.1 > 192.168.0.2, if 1 > 65535, 1 pkts, 60 bytes,
    ICMP 8:0, time 8...9

That is, a one-packet flow was shown to have more than a momentary
duration, which doesn't make sense.

This commit fixes the problem by making sure that creating a facet and then
its initial subfacet only checks the current time once.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit fea9f2006afb73d065621f36efbb93a5ef1edacd
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fea9f2006afb73d065621f36efbb93a5ef1edacd
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif: Avoid searching all subfacets when creating first in a facet.
		
When we create the first subfacet within a facet, we know that there
cannot be an existing subfacet with the same key, so we can skip the search
through the ofproto's table of subfacets.

This is a small optimization, but it should not affect the flow setup rate
in most benchmarks, because in the stressful situations that benchmarks
create, OVS does not set up flows.

Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif.c |   34 +++++++++++++++++++++++-----------
 1 files changed, 23 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
Open vSwitch