[ovs-git] Open vSwitch: rconn: Maintain original allowed_versions instead of substituting for zero. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Dec 5 02:24:14 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  5b8ab80c0897d9cc91488505a447dcf4a4e4b448 (commit)
      from  314e60e19507f12b89faaf8e605bd8e818cfe0a2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5b8ab80c0897d9cc91488505a447dcf4a4e4b448
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5b8ab80c0897d9cc91488505a447dcf4a4e4b448
Author: Ben Pfaff <blp at nicira.com>
		
rconn: Maintain original allowed_versions instead of substituting for zero.
		
rconn_create() was substituting OFPUTIL_DEFAULT_VERSIONS if an
allowed_versions of 0 was passed in.  At the same time,
connmgr_set_controllers() compared the adjusted value of allowed_versions
against the original value, saw that they were different, and concluded
that it should kill off and recreate the rconn with the "corrected"
allowed_versions.

This commit fixes the problem by no longer adjusting allowed_versions.
There is no need, because it is only used in contexts where the original
version is OK.

This problem was introduced by commit 90ef0206ea8f5a39 (connmgr:
Reinitialise controllers if protocols changes).

Bug #14126.
CC: Simon Horman <horms at verge.net.au>
Reported-by: Natasha Gude <natasha at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/rconn.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list