[ovs-git] Open vSwitch: nx-match: Log a warning when a wildcarded bit is set to 1. (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  e1cfc4e4612594746483dbe82607b1ba339b5b6c (commit)
      from  373be31fa1c25f0ed52f18a2ec2536591467e1a9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e1cfc4e4612594746483dbe82607b1ba339b5b6c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e1cfc4e4612594746483dbe82607b1ba339b5b6c
Author: Ben Pfaff <blp at nicira.com>
		
nx-match: Log a warning when a wildcarded bit is set to 1.
		
This was prompted by a conversation on the openflow-discuss mailing list
where developers of some OpenFlow switches mentioned that they save an
entire copy of raw flows passed in by controllers because of the
possibility that there might be wildcarded 1-bits, e.g. something like
192.168.1.1/255.255.0.0 instead of 192.168.0.0/255.255.0.0.  I've always
intended that this not be necessary, but it was never explicitly written
down.  This commit starts the process of updating OVS to make this a
requirement, by logging a warning whenever such a NXM or OXM entry is seen,
and by updating the spec in nicira-ext.h to describe my intent.

This is related to issue EXT-238 (OXM should require that 0-bits in mask
be 0-bits in value) in the Open Networking Foundation's "extensibility"
bugtracker at https://www.opennetworking.org/bugs/browse/EXT-238.
(Unfortunately one must be an employee of an ONF member company to
access this bug tracker.  It's the network that's open, not the
foundation.)

Thanks to Zoltán Lajos Kis, Dan Talayco, Rob Sherwood, and HIDEyuki
Shimonishi for participating in the discussion on openflow-discuss.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Kyle Mestery <kmestery at cisco.com>


-----------------------------------------------------------------------

Summary of changes:
 include/openflow/nicira-ext.h |    7 ++++---
 lib/nx-match.c                |   26 ++++++++++++++++++++++++++
 tests/ovs-ofctl.at            |   23 +++++++++++++++++++++--
 3 files changed, 51 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Open vSwitch