[ovs-git] Open vSwitch: meta-flow: Don't allow negative port numbers. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Dec 14 00:31:59 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  05dddbac2fd8652409a1a377fcebfd46c35673be (commit)
       via  d047fd17b88dab301d01a67ac6531865767aeeca (commit)
      from  066f329e29d5ff0b97ef77a5711d87ed53eef73d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 05dddbac2fd8652409a1a377fcebfd46c35673be
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=05dddbac2fd8652409a1a377fcebfd46c35673be
Author: Justin Pettit <jpettit at nicira.com>
		
meta-flow: Don't allow negative port numbers.
		
If a negative number is supplied, the parsing code used to convert it
into a signed one.  We ran into an incident where a third-party script
was attempting to get the OpenFlow port number for an interface, but got
-1 from the database, since the number had not yet been assigned.  This
was converted to 65535, which maps to OFPP_NONE and all flows with
ingress port OFPP_NONE were modified.  This commit disallows negative
port numbers to help prevent broken integration scripts from disturbing
the flow table.

Issue #14036

Signed-off-by: Justin Pettit <jpettit at nicira.com>


commit d047fd17b88dab301d01a67ac6531865767aeeca
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d047fd17b88dab301d01a67ac6531865767aeeca
Author: Justin Pettit <jpettit at nicira.com>
		
ofp-util: Fix typo in invalid port range error message.
		
Signed-off-by: Justin Pettit <jpettit at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/meta-flow.c |    5 ++++-
 lib/ofp-util.c  |    2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list