[ovs-git] Open vSwitch: meta-flow: Don't allow negative port numbers. (branch-1.4)

dev at openvswitch.org dev at openvswitch.org
Fri Dec 14 00:36:06 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.4 has been updated
       via  8963743a95f53933249e468492b163747f1b2b73 (commit)
      from  aa8d2ee8ae0d47f1683cf51e83f104022102ed73 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8963743a95f53933249e468492b163747f1b2b73
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8963743a95f53933249e468492b163747f1b2b73
Author: Justin Pettit <jpettit at nicira.com>
		
meta-flow: Don't allow negative port numbers.
		
If a negative number is supplied, the parsing code used to convert it
into a signed one.  We ran into an incident where a third-party script
was attempting to get the OpenFlow port number for an interface, but got
-1 from the database, since the number had not yet been assigned.  This
was converted to 65535, which maps to OFPP_NONE and all flows with
ingress port OFPP_NONE were modified.  This commit disallows negative
port numbers to help prevent broken integration scripts from disturbing
the flow table.

Issue #14036

Signed-off-by: Justin Pettit <jpettit at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/meta-flow.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list