[ovs-git] Open vSwitch: ofproto, ofproto-dpif: Fix memory leaks of struct iface_hint structures. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Dec 18 23:56:01 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  4f9e08a539f26b008f32a33b86ef8c46f5c5bab9 (commit)
       via  c83b89ab6da8704b140ec51cd5bae10448b510cb (commit)
       via  5b5e6a4c7525576ffe44aa9b7e67b3fd49ea2501 (commit)
       via  476cb42a5c638311b84a4015ae8058b536ff467f (commit)
      from  1b567fb9afb3259646b7171eea38787d610a212c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4f9e08a539f26b008f32a33b86ef8c46f5c5bab9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4f9e08a539f26b008f32a33b86ef8c46f5c5bab9
Author: Ben Pfaff <blp at nicira.com>
		
ofproto, ofproto-dpif: Fix memory leaks of struct iface_hint structures.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit c83b89ab6da8704b140ec51cd5bae10448b510cb
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c83b89ab6da8704b140ec51cd5bae10448b510cb
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif: Fix another memory leak in type_run().
		
'devname' needs to be destroyed whether it's the datapath device or not.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 5b5e6a4c7525576ffe44aa9b7e67b3fd49ea2501
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5b5e6a4c7525576ffe44aa9b7e67b3fd49ea2501
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif: Fix memory leak in type_run().
		
The dpif_port_destroy() call was in the dpif_port_query_by_name() error
path, when there's nothing to destroy, rather than in the "success" path,
where there is data to destroy.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 476cb42a5c638311b84a4015ae8058b536ff467f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=476cb42a5c638311b84a4015ae8058b536ff467f
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif: Avoid potential undefined behavior in type_run().
		
When HMAP_FOR_EACH completes, the value in the loop control variable is not
necessarily NULL.  It is NULL minus the offset of the hmap_node struct
member, which is nonnull if that offset is nonzero.  Currently,
'all_ofproto_dpifs_node' is the first member in struct ofproto_dpif, so
there is no real bug, but there would be if the struct were rearranged.

This commit heads off the problem by avoiding any assumption about the
loop control variable after HMAP_FOR_EACH.

Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif.c |   32 +++++++++++++++++++++-----------
 ofproto/ofproto.c      |    3 ++-
 2 files changed, 23 insertions(+), 12 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list