[ovs-git] Open vSwitch: datapath: Initialize tunnel_key pad member. (branch-1.9)

dev at openvswitch.org dev at openvswitch.org
Mon Dec 31 21:04:49 UTC 2012

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.9 has been updated
       via  968b25dc15d34373e6f98f8fe6aa8d4dc1356524 (commit)
      from  91184c191c2a7d931d51d21cfccd9357ade07457 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 968b25dc15d34373e6f98f8fe6aa8d4dc1356524
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=968b25dc15d34373e6f98f8fe6aa8d4dc1356524
Author: Jesse Gross <jesse at nicira.com>
datapath: Initialize tunnel_key pad member.
When a packet is received on a tunnel the pad member is currently
left uninitialized.  This didn't previously cause problems because
userspace didn't interprete the IPV4_TUNNEL attribute and blindly
copied back the uninitialized data.  However, now that userspace
knows how to serialize this attribute it was zeroing it out, which
prevented flows that had been previously installed from being
deleted.  In addition to zeroing out the padding on packet reception,
it also does the same thing on flow setup since we should be ignoring
the value.

Reported-by: Anand Krishnamurthy <krishnamurt4 at wisc.edu>
Reported-by: Saul St. John <sstjohn at cs.wisc.edu>
Signed-off-by: Jesse Gross <jesse at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>




Summary of changes:
 datapath/flow.c   |    4 ++++
 datapath/tunnel.h |    1 +
 2 files changed, 5 insertions(+), 0 deletions(-)

Open vSwitch

More information about the git mailing list