[ovs-git] Open vSwitch: tests: Reduce risk of port collision and remove bash dependency. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Feb 3 00:37:37 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  37b694e7a76ca6abc62c78eceae26f655cf6bccf (commit)
      from  7d0c5973d5165f3cc6099de326ad0dfc326bac33 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 37b694e7a76ca6abc62c78eceae26f655cf6bccf
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=37b694e7a76ca6abc62c78eceae26f655cf6bccf
Author: Ben Pfaff <blp at nicira.com>
		
tests: Reduce risk of port collision and remove bash dependency.
		
A few tests need a random TCP port on which to listen for connections.
Until now, the tests have used the $RANDOM bash extension to do this, but
this runs the risk of occasionally colliding with an in-use port.  This
commit removes the bash dependency by switching to using a small Perl
program to pick random ports and reduces the risk of collision by
attempting to bind the port that it chooses.

Reported-by: Timothy Chen <tchen at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 AUTHORS               |    1 +
 tests/automake.mk     |    2 ++
 tests/choose-port.pl  |   26 ++++++++++++++++++++++++++
 tests/ofproto-dpif.at |    8 ++++----
 tests/ovsdb-server.at |    8 ++++----
 5 files changed, 37 insertions(+), 8 deletions(-)
 create mode 100644 tests/choose-port.pl


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list