[ovs-git] Open vSwitch: ofproto-dpif: Keep subfacets longer to avoid assert-fail in facet_account(). (branch-1.4)

dev at openvswitch.org dev at openvswitch.org
Sat Jan 7 01:02:46 UTC 2012

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.4 has been updated
       via  b87dd2dcf4a2af434d1b92f6efcb32f54fee03b2 (commit)
      from  2716b6379dc86331330d78b496985e908320ddfa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b87dd2dcf4a2af434d1b92f6efcb32f54fee03b2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b87dd2dcf4a2af434d1b92f6efcb32f54fee03b2
Author: Ben Pfaff <blp at nicira.com>
ofproto-dpif: Keep subfacets longer to avoid assert-fail in facet_account().
If a subfacet expired when its facet still had statistics that had not
yet been pushed into the rule, and the facet either used the "normal"
action or the bridge contained a bond port, then facet_account() would
be called after the last subfacet was removed from its facet's list of
subfacets, triggering an assertion failure in list_front().

This fixes the problem by always running facet_flush_stats() (which calls
facet_account()) before deleting the last subfacet from a facet.

This problem took a while to surface because subfacets usually expire only
long after their statistics have been pushed into the rule.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Reported-by: Mike Kruze <mkruze at nicira.com>
Bug #9074.


Summary of changes:
 AUTHORS                |    1 +
 ofproto/ofproto-dpif.c |   23 +++++++++++++++++++----
 2 files changed, 20 insertions(+), 4 deletions(-)

Open vSwitch

More information about the git mailing list