[ovs-git] Open vSwitch: dpif: Simplify the "listen mask" concept. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Jan 13 01:09:28 UTC 2012

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  a12b3eadc64573c132e3630c5602be3c9b7f7156 (commit)
      from  300c69464ca88ca97d4ce842b590ce6ce603201b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a12b3eadc64573c132e3630c5602be3c9b7f7156
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a12b3eadc64573c132e3630c5602be3c9b7f7156
Author: Ben Pfaff <blp at nicira.com>
dpif: Simplify the "listen mask" concept.
At one point in the past, there were three separate queues between the
kernel module and OVS userspace, each of which corresponded to a Netlink
socket (or, before that, to a character device).  It made sense to allow
each of these to be enabled or disabled separately, hence the "listen mask"
concept in the dpif layer.

These days, the concept is much less clear-cut.  Queuing is no longer on
the basis of different classes of packets but instead striped across a
collection of sockets based on input port.  It doesn't really make sense
to enable receiving packets on the basis of the kind of packet anymore.
Accordingly, this commit simplifies the "listen_mask" to just a bool that
either enables or disables receiving packets.

It could be useful to enable or disable receiving packets on a per-vport
basis, but the rest of the code isn't ready to make use of that so this
commit doesn't generalize this much.

Based on this discussion on ovs-dev:

Signed-off-by: Ben Pfaff <blp at nicira.com>


Summary of changes:
 lib/dpif-linux.c       |   52 ++++++++++++-----------------------------------
 lib/dpif-netdev.c      |   21 ++----------------
 lib/dpif-provider.h    |   20 ++++-------------
 lib/dpif.c             |   46 +++++++-----------------------------------
 lib/dpif.h             |    3 +-
 ofproto/ofproto-dpif.c |    4 +--
 6 files changed, 32 insertions(+), 114 deletions(-)

Open vSwitch

More information about the git mailing list