[ovs-git] Open vSwitch: ofproto-dpif: Implement self-check of flow translations. (master)

dev at openvswitch.org dev at openvswitch.org
Mon Jan 16 20:39:24 UTC 2012

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  6814e51f41074afdfc13ea2ca1a462b873c7cd49 (commit)
       via  15baa734dbe26167aca7b5ed92ff1061209355a9 (commit)
      from  f0fd1a1772665ea57662281d9cccadb0f0146196 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6814e51f41074afdfc13ea2ca1a462b873c7cd49
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6814e51f41074afdfc13ea2ca1a462b873c7cd49
Author: Ben Pfaff <blp at nicira.com>
ofproto-dpif: Implement self-check of flow translations.
One of the major tasks of ofproto-dpif is to translate OpenFlow
actions into "ODP" datapath actions.  These translations are essentially
a cache that requires revalidation when certain state changes occur.  For
best performance it's important to revalidate flows only when necessary,
so from time to time Open vSwitch has gotten this wrong, which meant that
stale flows could persist in the kernel and cause surprising behavior.

This commit implements a simple "self check": every trip through the
Open vSwitch main loop randomly chooses one flow entry and checks that
its actions have been correctly translated.  If not, Open vSwitch logs
the details of the problem.  This should help find problems more
quickly in the future.

Signed-off-by: Ben Pfaff <blp at nicira.com>

commit 15baa734dbe26167aca7b5ed92ff1061209355a9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=15baa734dbe26167aca7b5ed92ff1061209355a9
Author: Ben Pfaff <blp at nicira.com>
ofproto-dpif: Remove many redundant "struct ofproto_dpif *" parameters.
It's redundant to pass both a facet or subfacet and an ofproto_dpif,
because the latter can be derived from the former.

Signed-off-by: Ben Pfaff <blp at nicira.com>


Summary of changes:
 lib/odp-util.c              |   20 +++-
 lib/odp-util.h              |    3 +-
 ofproto/ofproto-dpif.c      |  319 ++++++++++++++++++++++++++++++++++---------
 ofproto/ofproto-unixctl.man |    7 +
 4 files changed, 280 insertions(+), 69 deletions(-)

Open vSwitch

More information about the git mailing list