[ovs-git] Open vSwitch: dpif: Log each operation in dpif_operate(). (master)

dev at openvswitch.org dev at openvswitch.org
Mon Jan 16 21:38:53 UTC 2012

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  f23d28456f4ce2c4720a9c100ceff828b79c2360 (commit)
       via  89625d1efb32461071837b5e81c1238b4ca63387 (commit)
       via  c2b565b54e36bc33d0406afb225c9bf3d01405ef (commit)
      from  8338659aa5a02421959bece64f6233216de6a101 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f23d28456f4ce2c4720a9c100ceff828b79c2360
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f23d28456f4ce2c4720a9c100ceff828b79c2360
Author: Ben Pfaff <blp at nicira.com>
dpif: Log each operation in dpif_operate().
Without logging of operation groups, it becomes more difficult to debug
problems related to flow setups, since those go through operation groups.

Signed-off-by: Ben Pfaff <blp at nicira.com>

commit 89625d1efb32461071837b5e81c1238b4ca63387
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=89625d1efb32461071837b5e81c1238b4ca63387
Author: Ben Pfaff <blp at nicira.com>
dpif: Change provider interface to consistently use operation structs.
Until now, a "flow put" has represented its parameters in two different
ways, depending on whether it was coming from dpif_flow_put() or from
dpif_operate(), and similarly for an "execute" operation.  This commit
adopts the operation struct consistently within the dpif provider
interface, which seems cleaner.

This commit also factors out logging for flow puts and executes, which
is useful in the following commit.

This doesn't change the dpif client interface, since the two forms are
more convenient for clients than always filling out an operation struct.

Signed-off-by: Ben Pfaff <blp at nicira.com>

commit c2b565b54e36bc33d0406afb225c9bf3d01405ef
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c2b565b54e36bc33d0406afb225c9bf3d01405ef
Author: Ben Pfaff <blp at nicira.com>
dpif: Factor 'type' and 'error' out of individual dpif_op members.
I'd like to change ->dpif_flow_put() and ->dpif_execute() in the dpif
provider to take the structures of the same names as parameters, instead of
passing them discrete parameters, because this seems like a more sensible
way to do things internally than to have two different ways to pass the
parameters.  It might even simplify code slightly.  But ->flow_put() and
->execute() wouldn't want the 'type' (because it's implied by the function
being called) or 'error' (because it would be the same as the return
value).  Although of course they could just ignore those members, it seems
slightly cleaner to omit them entirely, as this change allows.

Signed-off-by: Ben Pfaff <blp at nicira.com>


Summary of changes:
 lib/dpif-linux.c       |  106 ++++++++++++---------------
 lib/dpif-netdev.c      |   42 +++++------
 lib/dpif-provider.h    |   46 ++++++-------
 lib/dpif.c             |  189 +++++++++++++++++++++++++++++++-----------------
 lib/dpif.h             |   20 ++----
 ofproto/ofproto-dpif.c |   18 ++---
 6 files changed, 222 insertions(+), 199 deletions(-)

Open vSwitch

More information about the git mailing list