[ovs-git] Open vSwitch: ovs-vswitchd: Log datapath ID in a more user-friendly way. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Jul 5 22:25:18 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  e825ace22c8f863e806ff2ac9a6f58a4e112ee5c (commit)
       via  fbfa291126a76ace115ca81d02801ad02cd0f218 (commit)
      from  247cd777a12fae3ff37da762f8016fee82bbf411 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e825ace22c8f863e806ff2ac9a6f58a4e112ee5c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e825ace22c8f863e806ff2ac9a6f58a4e112ee5c
Author: Ben Pfaff <blp at nicira.com>
		
ovs-vswitchd: Log datapath ID in a more user-friendly way.
		
The layering between ofproto and ovs-vswitchd caused the datapath ID to be
logged in a needlessly confusing way.  First, ofproto would log its
default datapath ID:

     using datapath ID 0000505400000004

then the bridge code would immediately determine the datapath ID that it
wanted and call ofproto_set_datapath_id(), which would log the change

     datapath ID changed to 0000111122223333

This commit stops logging the default datapath ID, which is never actually
visible in OpenFlow.  This should make the log files easier to understand.

Bug #12164.
Reported-by: Jacob Cherkas <jcherkas at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit fbfa291126a76ace115ca81d02801ad02cd0f218
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fbfa291126a76ace115ca81d02801ad02cd0f218
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Always include ofproto name in log messages.
		
Otherwise the log messages can be confusing when there's more than one
bridge.

Reported-by: Jacob Cherkas <jcherkas at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto.c |   65 +++++++++++++++++++++++++++++-----------------------
 ofproto/ofproto.h |    1 +
 vswitchd/bridge.c |    5 +++-
 3 files changed, 41 insertions(+), 30 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list