[ovs-git] Open vSwitch: ovs-ofctl: Avoid printing false differences on "ovs-ofctl diff-flows". (branch-1.8)

dev at openvswitch.org dev at openvswitch.org
Wed Jul 25 20:11:41 UTC 2012

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.8 has been updated
       via  e23285a6725a21183e31b9a49ee19c0747d1f0fa (commit)
      from  64452d5c7bfb01f2eb65ac22e394c4cc9ea1c53d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e23285a6725a21183e31b9a49ee19c0747d1f0fa
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e23285a6725a21183e31b9a49ee19c0747d1f0fa
Author: Ben Pfaff <blp at nicira.com>
ovs-ofctl: Avoid printing false differences on "ovs-ofctl diff-flows".
It is possible for "struct ofpact"s to differ bytewise even if they are
equivalent when converted to another representation, such as OpenFlow 1.0
action format or a string representation.  This can cause "ovs-ofctl
diff-flows" to print surprising false "differences", e.g. as in the bug

    - actions=resubmit(,1)
    + actions=resubmit(,1)

This commit fixes the problem by comparing not just the ofpacts but also
the string representation and printing a difference only if both differ.

Bug #8899.
Reported-by: Luca Giraudo <lgiraudo at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Summary of changes:
 tests/ovs-ofctl.at    |   25 +++++++++++++++++++++
 utilities/ovs-ofctl.c |   56 +++++++++++++++++++++++++++++-------------------
 2 files changed, 59 insertions(+), 22 deletions(-)

Open vSwitch

More information about the git mailing list