[ovs-git] Open vSwitch: Avoid implementation-defined strerror behaviour (branch-1.4)

dev at openvswitch.org dev at openvswitch.org
Fri Jul 27 21:32:58 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.4 has been updated
       via  d6af664b9a4465214e80cf5b6be95b3f5a8683ed (commit)
      from  21c9a7ede8b3046459699beb233a5e07079f92d9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d6af664b9a4465214e80cf5b6be95b3f5a8683ed
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d6af664b9a4465214e80cf5b6be95b3f5a8683ed
Author: Ed Maste <emaste at adaranet.com>
		
Avoid implementation-defined strerror behaviour
		
POSIX states that the string returned by strerror() may be overwritten
by a subsequent call (i.e., because it returns a pointer to a static
buffer).  Make a copy of one of the two strerror() strings to avoid
this.

Background: FreeBSD historically returned such a pointer only in the
case of an invalid errno.  With the addition of NLS strerror was changed
to do so for all calls.

Prior to this change I had confusing results from the test suite like
"... is 22 (Invalid argument) but should be 0 (Invalid argument)".

Signed-off-by: Ed Maste <emaste at adaranet.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 tests/test-vconn.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list