[ovs-git] Open vSwitch: dpif-linux: Log details when a packet is lost. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Jun 1 21:42:55 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  14b4d2f99f861e63093ce684e8073ba6e878243b (commit)
       via  fe3d61b373bd274fd7cd8bff46f3edbe03fa673f (commit)
       via  e222833e3915daacf8e22d97290a6e901206a405 (commit)
       via  cf1b8a921b4a1b660648925377783b7bbe92fb3e (commit)
      from  a6492d9187196583d1a183a1559bc594af475123 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 14b4d2f99f861e63093ce684e8073ba6e878243b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=14b4d2f99f861e63093ce684e8073ba6e878243b
Author: Ben Pfaff <blp at nicira.com>
		
dpif-linux: Log details when a packet is lost.
		
Until now, when a packet was dropped in the kernel-to-user buffers, we
logged the occurrence but nothing that would allow a person reading the
log after the fact to learn why it was dropped.  This commit adds details
that identify the major sources of packets in the buffer, which should
help.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit fe3d61b373bd274fd7cd8bff46f3edbe03fa673f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fe3d61b373bd274fd7cd8bff46f3edbe03fa673f
Author: Ben Pfaff <blp at nicira.com>
		
dpif-linux: Slightly refactor internal data structures.
		
An initial attempt also replaced the 'uint32_t ready_mask' in struct
dpif_linux by a 'bool ready' in each struct dpif_channel, but I wasn't
happy with the result (the ready_mask bitmap works out really well) and so
I dropped that part.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit e222833e3915daacf8e22d97290a6e901206a405
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e222833e3915daacf8e22d97290a6e901206a405
Author: Ben Pfaff <blp at nicira.com>
		
dpif-linux: Avoid pessimal behavior when kernel-to-user buffers overflow.
		
When a kernel-to-user Netlink buffer overflows, the kernel reports
ENOBUFS without passing along an actual message.  When it does this,
we should immediately try again, because we know that there is a
message waiting, instead of reporting the error to the caller.

This improves the OVS response rate to "hping3 --flood" traffic by
a few percentage points in my testing.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit cf1b8a921b4a1b660648925377783b7bbe92fb3e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=cf1b8a921b4a1b660648925377783b7bbe92fb3e
Author: Ben Pfaff <blp at nicira.com>
		
poll-loop: More strictly rate-limit high CPU use logging.
		
120 messages per minute just isn't helpful.

Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/dpif-linux.c |  243 ++++++++++++++++++++++++++++++++++++++++++++++-------
 lib/poll-loop.c  |    4 +-
 2 files changed, 213 insertions(+), 34 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list