[ovs-git] Open vSwitch: ofproto-dpif: Avoid calling eth_addr_is_reserved(). (master)

dev at openvswitch.org dev at openvswitch.org
Thu Jun 7 01:34:46 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  614ec445172f05128b54e20ba6aebc1f35668b67 (commit)
       via  c93f9a78c349dee759524861a6e80694675283fc (commit)
       via  05be4e2c6af8ce22bd262820bc951c9408a6de3d (commit)
       via  3b842fc2f0f8367d7d1350a80f7c29edca0925b5 (commit)
      from  aecfb4af7e87a78dfec44db1fa82c4463a7f8309 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 614ec445172f05128b54e20ba6aebc1f35668b67
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=614ec445172f05128b54e20ba6aebc1f35668b67
Author: Ethan Jackson <ethan at nicira.com>
		
ofproto-dpif: Avoid calling eth_addr_is_reserved().
		
eth_addr_is_reserved() is a bit more expensive than it used to be,
so it makes sense to avoid calling it when convenient as an
optimization.

Signed-off-by: Ethan Jackson <ethan at nicira.com>


commit c93f9a78c349dee759524861a6e80694675283fc
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c93f9a78c349dee759524861a6e80694675283fc
Author: Ethan Jackson <ethan at nicira.com>
		
packets: Update the reserved protocols list.
		
The protocols added in this patch should be considered "reserved"
and not forward when "forward-bpdu" is false, nor should they be
mirrored.

Bug #11755.
Signed-off-by: Ethan Jackson <ethan at nicira.com>


commit 05be4e2c6af8ce22bd262820bc951c9408a6de3d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=05be4e2c6af8ce22bd262820bc951c9408a6de3d
Author: Ethan Jackson <ethan at nicira.com>
		
packets: Generalize reserved RSPAN protocols.
		
Open vSwitch refuses to mirror certain destination addresses in
addition to those classified by eth_addr_is_reserved().  Looking
through the uses of eth_addr_is_reserved(), one finds that no
callers should be using the additional addresses which mirroring
drops.  This patch folds the additional addresses dropped in the
mirroring code, into the more general eth_addr_is_reserverd()
function.

This patch also changes the implementation in a way that is
slightly less efficient, but much easier to read and extend int he
future.

Bug #11755.
Signed-off-by: Ethan Jackson <ethan at nicira.com>


commit 3b842fc2f0f8367d7d1350a80f7c29edca0925b5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3b842fc2f0f8367d7d1350a80f7c29edca0925b5
Author: Ethan Jackson <ethan at nicira.com>
		
packets: Fix eth_addr_equal_except().
		
It turns out that eth_addr_equal_except() computed the exact
opposite of what it purported to.  It returned true if the two
arguments where *not* equal.  This is extremely confusing, so this
patch changes it.

Signed-off-by: Ethan Jackson <ethan at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 NEWS                    |    2 +
 lib/classifier.c        |    8 ++--
 lib/packets.c           |   65 ++++++++++++++++++++++++++++++++++++++
 lib/packets.h           |   24 ++++----------
 ofproto/ofproto-dpif.c  |   47 ++--------------------------
 tests/test-classifier.c |    8 ++--
 vswitchd/vswitch.xml    |   79 +++++++++++++++++++++++++++++-----------------
 7 files changed, 135 insertions(+), 98 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list