[ovs-git] Open vSwitch: ofproto-dpif-governor: Wake up only when there is genuinely work to do. (branch-1.7)

dev at openvswitch.org dev at openvswitch.org
Wed Jun 20 20:18:51 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.7 has been updated
       via  d6a556b757f6482aeb2d1762d6e85a0b5fe80b1e (commit)
      from  0428e519ceee3b0459936cda7c6d7723c5d0c272 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d6a556b757f6482aeb2d1762d6e85a0b5fe80b1e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d6a556b757f6482aeb2d1762d6e85a0b5fe80b1e
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif-governor: Wake up only when there is genuinely work to do.
		
Until now, governor_wait() has awakened the poll loop whenever the
generation timer expires, to allow it to shrink the governor to the next
smaller size in governor_run().  However, if the governor is already the
smallest possible size, then governor_run() will not have anything to do
and will not restart the timer, which means that governor_wait() will again
immediately wake up the poll loop, and we end up using 100% CPU.

This is kind of hard to trigger because normally the client will destroy
a governor in such a case.  However, if there are too many subfacets, the
client will keep even a minimum-size governor, triggering the bug.

Bug #12106.
Reported-by: Alex Yip <alex at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif-governor.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list