[ovs-git] Open vSwitch: dpif-linux: Zero 'stats' outputs of dpif_operate() ops on failure. (branch-1.7)

dev at openvswitch.org dev at openvswitch.org
Mon Jun 25 23:48:16 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.7 has been updated
       via  3af38c1d6d59b4fe6eeb65c7fdfd3a896c5437c3 (commit)
      from  d6a556b757f6482aeb2d1762d6e85a0b5fe80b1e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3af38c1d6d59b4fe6eeb65c7fdfd3a896c5437c3
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3af38c1d6d59b4fe6eeb65c7fdfd3a896c5437c3
Author: Ben Pfaff <blp at nicira.com>
		
dpif-linux: Zero 'stats' outputs of dpif_operate() ops on failure.
		
When DPIF_OP_FLOW_PUT or DPIF_OP_FLOW_DEL operations failed, they left
their 'stats' outputs uninitialized.  For DPIF_OP_FLOW_DEL, this meant that
the caller would read indeterminate data:

Conditional jump or move depends on uninitialised value(s)
   at 0x805C1EB: subfacet_reset_dp_stats (ofproto-dpif.c:4410)
    by 0x80637D2: expire_batch (ofproto-dpif.c:3471)
    by 0x8066114: run (ofproto-dpif.c:3513)
    by 0x8059DF4: ofproto_run (ofproto.c:1035)
    by 0x8052E17: bridge_run (bridge.c:2005)
    by 0x8053F74: main (ovs-vswitchd.c:108)

It's unusual for a delete operation to fail.  The most common reason is an
administrator running "ovs-dpctl del-flows".

The only user of DPIF_OP_FLOW_PUT did not request stats, so this doesn't
fix an actual bug for that case.

Bug #11797.
Reported-by: James Schmidt <jschmidt at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/dpif-linux.c |   34 ++++++++++++++++++++++++----------
 1 files changed, 24 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list