[ovs-git] Open vSwitch: ofp-parse: Mark ofp_fatal() as never returning. (master)

dev at openvswitch.org dev at openvswitch.org
Mon May 14 18:20:55 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  99b671839071cbf1c2a68d2c8e9403717d3a1556 (commit)
       via  f4dace9c281baa7cb133ba0bc2dd997386389eed (commit)
       via  f5cd6874f1e4efcd1d513a294bf7709933959b97 (commit)
       via  d7127d44be0b18808b89717cbcb5be3afca92c11 (commit)
       via  4ceb7081c1fbd1bfa8c0e26cc45f3c803525fc3f (commit)
      from  66fb94b510164047e571af9a2bab8046bb9e192f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 99b671839071cbf1c2a68d2c8e9403717d3a1556
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=99b671839071cbf1c2a68d2c8e9403717d3a1556
Author: Ben Pfaff <blp at nicira.com>
		
ofp-parse: Mark ofp_fatal() as never returning.
		
This makes clang less confused.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit f4dace9c281baa7cb133ba0bc2dd997386389eed
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f4dace9c281baa7cb133ba0bc2dd997386389eed
Author: Ben Pfaff <blp at nicira.com>
		
ovs-ofctl: Avoid impossible check for !osm in fetch_port_by_stats().
		
At the time of the call to ofpbuf_at(), we know that the ofp_stats_msg is
present because ofputil_decode_msg_type() reported that it was.  Therefore,
we can use ofpbuf_at_assert() and don't have to check for a null pointer.

Found by clang.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit f5cd6874f1e4efcd1d513a294bf7709933959b97
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f5cd6874f1e4efcd1d513a294bf7709933959b97
Author: Ben Pfaff <blp at nicira.com>
		
Avoid writes to variables that are never read back.
		
Found by clang.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit d7127d44be0b18808b89717cbcb5be3afca92c11
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d7127d44be0b18808b89717cbcb5be3afca92c11
Author: Ben Pfaff <blp at nicira.com>
		
Avoid assigning the same value to a variable back-to-back.
		
Found by clang.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 4ceb7081c1fbd1bfa8c0e26cc45f3c803525fc3f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4ceb7081c1fbd1bfa8c0e26cc45f3c803525fc3f
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Remove write-only variable.
		
Found by clang.

Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/ofp-parse.c        |    3 +++
 lib/ofp-print.c        |    2 +-
 ofproto/ofproto-dpif.c |    1 -
 ofproto/ofproto.c      |    3 +--
 tests/test-util.c      |    1 -
 utilities/ovs-ofctl.c  |    4 ++--
 utilities/ovs-vsctl.c  |    2 --
 7 files changed, 7 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list