[ovs-git] Open vSwitch: odp-util: Update ODPUTIL_FLOW_KEY_BYTES for current kernel flow format. (master)

dev at openvswitch.org dev at openvswitch.org
Fri May 25 17:06:59 UTC 2012

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  2508ac16defd417b94fb69689b6b1da4fbc76282 (commit)
      from  5498c01ff8180714bb74d765e9b98fed629f9d20 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2508ac16defd417b94fb69689b6b1da4fbc76282
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2508ac16defd417b94fb69689b6b1da4fbc76282
Author: Ben Pfaff <blp at nicira.com>
odp-util: Update ODPUTIL_FLOW_KEY_BYTES for current kernel flow format.
Before we submitted the kernel module upstream, we updated the flow format
by adding two fields to the description of packets with VLAN headers, but
we forgot to update ODPUTIL_FLOW_KEY_BYTES to reflect these changes.  The
result was that a maximum-length flow did not fit in the given space.

This fixes a crash processing IPv6 neighbor discovery packets with VLAN
headers received in a tunnel configured with key=flow or in_key=flow.

This updates some comments to better describe the implications of
ODPUTIL_FLOW_KEY_BYTES (suggested by Justin).

This also updates test-odp.c so that it would have caught this problem, and
updates odp.at to demonstrate that a full 156 bytes are necessary.  (To see
that, revert the change to ODPUTIL_FLOW_KEY_BYTES and run the test.)

Reported-by: Dan Wendlandt <dan at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Summary of changes:
 lib/odp-util.c   |    5 ++++-
 lib/odp-util.h   |   23 ++++++++++++++++++-----
 tests/odp.at     |    6 ++++++
 tests/test-odp.c |    9 ++++++++-
 4 files changed, 36 insertions(+), 7 deletions(-)

Open vSwitch

More information about the git mailing list