[ovs-git] Open vSwitch: ofproto: Better hide hidden tables. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Nov 2 17:38:17 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  c2f0373a8248d0c20d2f876d7f3bc61a400d9924 (commit)
      from  79aa9fd03de644e192fbdabc5073dc1755861203 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c2f0373a8248d0c20d2f876d7f3bc61a400d9924
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c2f0373a8248d0c20d2f876d7f3bc61a400d9924
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Better hide hidden tables.
		
ofproto has a concept of "hidden" OpenFlow tables.  Currently these are
used internally only for ofproto-dpif for a couple of unimportant
purposes.  However, hidden tables were not hidden well enough, because
OFTest was able to spot ofproto-dpif's hidden table and, seeing that it
had a couple of flows in it even after OFTest had tried to delete all
flows, failed at least one test.

This commit hides the tables better:

    - The number of tables reported in a feature reply no longer counts
      hidden tables.

    - Table stats replies omit hidden tables.

This commit introduces the requirement that hidden tables, if any, be the
highest-numbered tables.  This is because it's not clear to me that
OpenFlow intends to allow tables to be numbered noncontiguously.

We could take this further, by not exposing hidden tables in any way, but
I have this pet theory that being able to get the statistics for these
tables will come in handy for debugging someday.

Found by openflow_protocol_messages.ModifyStateDelete in OFTest.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Kyle Mestery <kmestery at cisco.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-provider.h |   23 +++++++++++++++++++++++
 ofproto/ofproto.c          |   32 ++++++++++++++++++++++++++++++--
 tests/ofproto.at           |   14 ++++++--------
 3 files changed, 59 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list