[ovs-git] Open vSwitch: socket-util: Report fd of -1 on error in inet_open_active(). (branch-1.9)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.9 has been updated
       via  27cdde0461846da719b753b79e52dd3cdcb23b24 (commit)
      from  669ce49a1e24100b6e9d4b98a727d0310aa13c8a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 27cdde0461846da719b753b79e52dd3cdcb23b24
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=27cdde0461846da719b753b79e52dd3cdcb23b24
Author: Ben Pfaff <blp at nicira.com>
		
socket-util: Report fd of -1 on error in inet_open_active().
		
inet_open_active() is documented to report a fd of -1 when an error occurs.
All three of its callers rely on this, by checking only the fd to determine
whether there was an error.  This means that if the call to
set_nonblocking() or set_dscp() or connect() failed, then the callers would
try to use a fd that had already been closed, wreaking havoc.

This fixes a bug introduced in commit a4efa3fc5d (socket-util: Close socket
on failed dscp modification.)

Bug #13750.
Reported-by: Scott Hendricks <shendricks at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/socket-util.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Open vSwitch