[ovs-git] Open vSwitch: datapath: Fix FLOW_BUFSIZE definition. (branch-1.8)

dev at openvswitch.org dev at openvswitch.org
Tue Sep 4 02:02:50 UTC 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.8 has been updated
       via  75cf119f39aa62a261cde2581e089055ee3344ff (commit)
      from  3b26739f65590d3d18edebec2efe0f72560197b5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 75cf119f39aa62a261cde2581e089055ee3344ff
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=75cf119f39aa62a261cde2581e089055ee3344ff
Author: Jesse Gross <jesse at nicira.com>
		
datapath: Fix FLOW_BUFSIZE definition.
		
This is analogous to the change made in userspace with
2508ac16defd417b94fb69689b6b1da4fbc76282 (odp-util: Update
ODPUTIL_FLOW_KEY_BYTES for current kernel flow format.).  The extra
space for vlan encapsulation was not included in the allocation for
maximum length flows.

Found by code inspection and to my knowledge has never been hit, likely
because skb allocations are padded out to a cacheline, making userspace
more susceptible to this problem than the kernel.  In theory, however,
the right combination of flow and packet size could result in a kernel
panic.

Signed-off-by: Jesse Gross <jesse at nicira.com>
Acked-by: Kyle Mestery <kmestery at cisco.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/flow.h |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list