[ovs-git] Open vSwitch: ofp-errors: Use standardised code for OFPERR_OFPBMC_BAD_VALUE (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  130b77cd9451731b0dcca077ad61e026109d53b5 (commit)
       via  fb9515e1fd7f60d9720ccdecd3cb23c7b852f045 (commit)
       via  e38c9de5db32342b86f177e9fbd4e1dab77a2a1f (commit)
      from  5cb7a798405c6ccc07bf9a932b709643c072b086 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 130b77cd9451731b0dcca077ad61e026109d53b5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=130b77cd9451731b0dcca077ad61e026109d53b5
Author: Simon Horman <horms at verge.net.au>
		
ofp-errors: Use standardised code for OFPERR_OFPBMC_BAD_VALUE
		
Use standardised code for Open Flow 1.1 OFPERR_OFPBMC_BAD_VALUE

OFPERR_OFPBMC_BAD_VALUE is defined in Open Flow 1.1 as (4,7),
so use that code instead of a non-standard one.

Signed-off-by: Simon Horman <horms at verge.net.au>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit fb9515e1fd7f60d9720ccdecd3cb23c7b852f045
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fb9515e1fd7f60d9720ccdecd3cb23c7b852f045
Author: Simon Horman <horms at verge.net.au>
		
ofp-errors: Remove OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED
		
OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED is currently only used in paths which
are part of a non-NX extension portions of the Open Flow 1.1+
implementation.

After recent discussion it has been decided to attempt to only use
standardised, albeit lest-specify, errors unless errors arise from use of
an NX extension.

With the above in mind it seems appropriate to:
* Use OFPERR_OFPFMFC_UNKNOWN in place of OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED.
* Remove OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED as it is no longer used.

An unfortunate side-effect of this change is that the error for
the case in question is now less-specific.

Signed-off-by: Simon Horman <horms at verge.net.au>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit e38c9de5db32342b86f177e9fbd4e1dab77a2a1f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e38c9de5db32342b86f177e9fbd4e1dab77a2a1f
Author: Simon Horman <horms at verge.net.au>
		
ofp-errors: Remove OFPERR_NXBIC_DUP_TYPE
		
OFPERR_NXBIC_DUP_TYPE is currently only used in
decode_openflow11_instructions() which is part of a non-NX extension
portion of the Open Flow 1.1+ implementation.

After recent discussion it has been decided to attempt to only use
standardised, albeit less-specific, errors unless errors arise from use of
an NX extension.

With the above in mind it seems appropriate to:
* Use OFPERR_OFPIT_BAD_INSTRUCTION in place of OFPERR_NXBIC_DUP_TYPE.
* Remove OFPERR_NXBIC_DUP_TYPE as it is no longer used.

An unfortunate side-effect of this change is that the error for
the case in question is now less-specific.

Signed-off-by: Simon Horman <horms at verge.net.au>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/ofp-actions.c    |    2 +-
 lib/ofp-errors.h     |    8 +-------
 lib/ofp-util.c       |    4 ++--
 tests/ofp-actions.at |    3 ++-
 4 files changed, 6 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
Open vSwitch